Merge pull request #697 from JakeStanger/refactor/dbus-error

refactor(mpris): better logging, avoid panic on dbus error
JakeStanger · Aug 10, 2024 · bba345a · bba345a
2 parents 860a676 + 1899757
commit bba345a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/clients/music/mpris.rs b/src/clients/music/mpris.rs
@@ -47,9 +47,12 @@ impl Client {
                         )) if transport_error.name() == Some(NO_ACTIVE_PLAYER)
                             || transport_error.name() == Some(NO_REPLY) =>
                         {
-                            Vec::new()
+                            vec![]
+                        }
+                        _ => {
+                            error!("D-Bus error getting MPRIS players: {e:?}");
+                            vec![]
                         }
-                        _ => panic!("Failed to connect to D-Bus"),
                     });
                     // Acquire the lock of current_player before players to avoid deadlock.
                     // There are places where we lock on current_player and players, but we always lock on current_player first.