Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

fix(schematics): application impl #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(schematics): application impl #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-expo/src/schematics/application/application.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function createApplicationFiles(options: NormalizedSchema): Rule {
}

function updateNxJson(options: NormalizedSchema): Rule {
return updateJsonInTree<NxJson>('nx.json', (json) => {
return updateJsonInTree<NxJson>('workspace.json', (json) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First @tk-o thanks for the contribution 💜
I think this is a breaking change. Maybe the setup of a migration path is needed.
Not sure if this will be easy to do or not.
I'm also rewriting a lot of code to support Nx12, and I will merge this when that work is done.

const parsedTags = options.tags
? options.tags.split(',').map((s) => s.trim())
: [];
Expand Down