This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
fix(schematics): application impl #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `workspace.json` file to write the project entry in. Fixes JacopoPatroclo#24
| @@ -77,7 +77,7 @@ function createApplicationFiles(options: NormalizedSchema): Rule { | |||
| } | |||
|
|
|||
| function updateNxJson(options: NormalizedSchema): Rule { | |||
| return updateJsonInTree<NxJson>('nx.json', (json) => { | |||
| return updateJsonInTree<NxJson>('workspace.json', (json) => { | |||
There was a problem hiding this comment.
First @tk-o thanks for the contribution 💜
I think this is a breaking change. Maybe the setup of a migration path is needed.
Not sure if this will be easy to do or not.
I'm also rewriting a lot of code to support Nx12, and I will merge this when that work is done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
workspace.jsonfile to write the project entry in. Fixes #24