Updates minimum supported SDK version to Flutter 3.13/Dart 3.1

This change is a continuation of this PR. flutter-tizen#675 This change will enable the lint option below and apply the changes. And update the SDK version to apply these lint options. This should be common to all plugins, so apply them together. - unnecessary_null_comparison - unawaited_futures - dangling_library_doc_comments - no_literal_bool_comparisons - unnecessary_library_directive - use_colored_box - use_enums - use_string_in_part_of_directives
JSUYA · Mar 12, 2024 · 6b6ede0 · 6b6ede0
1 parent 7a4d26f
commit 6b6ede0
Show file tree

Hide file tree

Showing 165 changed files with 383 additions and 372 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -12,7 +12,6 @@ analyzer:
     # something (https://github.com/flutter/flutter/issues/143312)
     deprecated_member_use: ignore
     deprecated_member_use_from_same_package: ignore
-    unnecessary_null_comparison: ignore # Temporarily ingnored from flutter-tizen.
   exclude: # DIFFERENT FROM FLUTTER/FLUTTER
     # Ignore generated files
     - '**/*.g.dart'
@@ -80,7 +79,7 @@ linter:
     # - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204
     - control_flow_in_finally
     - curly_braces_in_flow_control_structures
-    # - dangling_library_doc_comments # Temporarily ingnored from flutter-tizen.
+    - dangling_library_doc_comments
     - depend_on_referenced_packages
     - deprecated_consistency
     # - deprecated_member_use_from_same_package # we allow self-references to deprecated members
@@ -115,7 +114,7 @@ linter:
     - no_duplicate_case_values
     - no_leading_underscores_for_library_prefixes
     - no_leading_underscores_for_local_identifiers
-    # - no_literal_bool_comparisons # Temporarily ingnored from flutter-tizen.
+    - no_literal_bool_comparisons
     - no_logic_in_create_state
     - no_runtimeType_toString # DIFFERENT FROM FLUTTER/FLUTTER
     - no_self_assignments
@@ -189,7 +188,7 @@ linter:
     # - type_annotate_public_apis # subset of always_specify_types
     - type_init_formals
     - type_literal_in_constant_pattern
-    # - unawaited_futures # DIFFERENT FROM FLUTTER/FLUTTER: It's disabled there for "too many false positives"; that's not an issue here, and missing awaits have caused production issues in plugins. # Temporarily ingnored from flutter-tizen.
+    - unawaited_futures # DIFFERENT FROM FLUTTER/FLUTTER: It's disabled there for "too many false positives"; that's not an issue here, and missing awaits have caused production issues in plugins.
     - unnecessary_await_in_return
     - unnecessary_brace_in_string_interps
     - unnecessary_breaks
@@ -199,7 +198,7 @@ linter:
     - unnecessary_getters_setters
     # - unnecessary_lambdas # has false positives: https://github.com/dart-lang/linter/issues/498
     - unnecessary_late
-    # - unnecessary_library_directive # Temporarily ingnored from flutter-tizen.
+    - unnecessary_library_directive
     - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_aware_operator_on_extension_on_nullable
@@ -218,9 +217,9 @@ linter:
     - unrelated_type_equality_checks
     - unsafe_html
     - use_build_context_synchronously
-    # - use_colored_box # Temporarily ingnored from flutter-tizen.
+    - use_colored_box
     # - use_decorated_box # leads to bugs: DecoratedBox and Container are not equivalent (Container inserts extra padding)
-    # - use_enums # Temporarily ingnored from flutter-tizen.
+    - use_enums
     - use_full_hex_values_for_flutter_colors
     - use_function_type_syntax_for_parameters
     - use_if_null_to_convert_nulls_to_bools
@@ -232,7 +231,7 @@ linter:
     - use_rethrow_when_possible
     - use_setters_to_change_properties
     # - use_string_buffers # has false positives: https://github.com/dart-lang/sdk/issues/34182
-    # - use_string_in_part_of_directives # Temporarily ingnored from flutter-tizen.
+    - use_string_in_part_of_directives
     - use_super_parameters
     - use_test_throws_matchers
     # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review

diff --git a/packages/audioplayers/CHANGELOG.md b/packages/audioplayers/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+
 ## 3.0.1
 
 * Update audioplayers to 5.1.0.

diff --git a/packages/audioplayers/example/pubspec.yaml b/packages/audioplayers/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the audioplayers plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   audioplayers: ^5.1.0

diff --git a/packages/audioplayers/pubspec.yaml b/packages/audioplayers/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/audiop
 version: 3.0.1
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 flutter:
   plugin:

diff --git a/packages/battery_plus/CHANGELOG.md b/packages/battery_plus/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+
 ## 1.1.2
 
 * Update battery_plus to 4.0.1.

diff --git a/packages/battery_plus/example/pubspec.yaml b/packages/battery_plus/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the battery_plus plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   battery_plus: ^4.0.1

diff --git a/packages/battery_plus/pubspec.yaml b/packages/battery_plus/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/batter
 version: 1.1.2
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 flutter:
   plugin:

diff --git a/packages/camera/CHANGELOG.md b/packages/camera/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## NEXT
 
-* Increase the minimum Flutter version to 3.3.
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+* Fixes new lint warnings.
 
 ## 0.3.4
 

diff --git a/packages/camera/example/lib/main.dart b/packages/camera/example/lib/main.dart
@@ -250,9 +250,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
                         child: Center(
                           child: AspectRatio(
                               aspectRatio:
-                                  localVideoController.value.size != null
-                                      ? localVideoController.value.aspectRatio
-                                      : 1.0,
+                                  localVideoController.value.aspectRatio,
                               child: VideoPlayer(localVideoController)),
                         ),
                       ),
@@ -380,7 +378,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     return SizeTransition(
       sizeFactor: _exposureModeControlRowAnimation,
       child: ClipRect(
-        child: Container(
+        child: ColoredBox(
           color: Colors.grey.shade50,
           child: Column(
             children: <Widget>[
@@ -463,7 +461,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
     return SizeTransition(
       sizeFactor: _focusModeControlRowAnimation,
       child: ClipRect(
-        child: Container(
+        child: ColoredBox(
           color: Colors.grey.shade50,
           child: Column(
             children: <Widget>[
@@ -680,30 +678,23 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
       switch (e.code) {
         case 'CameraAccessDenied':
           showInSnackBar('You have denied camera access.');
-          break;
         case 'CameraAccessDeniedWithoutPrompt':
           // iOS only
           showInSnackBar('Please go to Settings app to enable camera access.');
-          break;
         case 'CameraAccessRestricted':
           // iOS only
           showInSnackBar('Camera access is restricted.');
-          break;
         case 'AudioAccessDenied':
           showInSnackBar('You have denied audio access.');
-          break;
         case 'AudioAccessDeniedWithoutPrompt':
           // iOS only
           showInSnackBar('Please go to Settings app to enable audio access.');
-          break;
         case 'AudioAccessRestricted':
           // iOS only
           showInSnackBar('Audio access is restricted.');
-          break;
         case 'cameraPermission':
           // Android & web only
           showInSnackBar('Unknown permission error.');
-          break;
         default:
           _showCameraException(e);
           break;
@@ -1001,7 +992,7 @@ class _CameraExampleHomeState extends State<CameraExampleHome>
         : VideoPlayerController.file(File(videoFile!.path));
 
     videoPlayerListener = () {
-      if (videoController != null && videoController!.value.size != null) {
+      if (videoController != null) {
         // Refreshing the state to update video player with the correct ratio.
         if (mounted) {
           setState(() {});

diff --git a/packages/camera/example/pubspec.yaml b/packages/camera/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the camera plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   camera: ^0.9.4

diff --git a/packages/camera/lib/camera_tizen.dart b/packages/camera/lib/camera_tizen.dart
@@ -536,7 +536,6 @@ class CameraTizen extends CameraPlatform {
         final Map<String, Object?> arguments = _getArgumentDictionary(call);
         _deviceEventStreamController.add(DeviceOrientationChangedEvent(
             deserializeDeviceOrientation(arguments['orientation']! as String)));
-        break;
       default:
         throw MissingPluginException();
     }
@@ -556,20 +555,17 @@ class CameraTizen extends CameraPlatform {
           deserializeFocusMode(arguments['focusMode']! as String),
           arguments['focusPointSupported']! as bool,
         ));
-        break;
       case 'resolution_changed':
         final Map<String, Object?> arguments = _getArgumentDictionary(call);
         _cameraEventStreamController.add(CameraResolutionChangedEvent(
           cameraId,
           arguments['captureWidth']! as double,
           arguments['captureHeight']! as double,
         ));
-        break;
       case 'camera_closing':
         _cameraEventStreamController.add(CameraClosingEvent(
           cameraId,
         ));
-        break;
       case 'video_recorded':
         final Map<String, Object?> arguments = _getArgumentDictionary(call);
         _cameraEventStreamController.add(VideoRecordedEvent(
@@ -579,14 +575,12 @@ class CameraTizen extends CameraPlatform {
               ? Duration(milliseconds: arguments['maxVideoDuration']! as int)
               : null,
         ));
-        break;
       case 'error':
         final Map<String, Object?> arguments = _getArgumentDictionary(call);
         _cameraEventStreamController.add(CameraErrorEvent(
           cameraId,
           arguments['description']! as String,
         ));
-        break;
       default:
         throw MissingPluginException();
     }

diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/camera
 version: 0.3.4
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   camera_platform_interface: ^2.1.1

diff --git a/packages/connectivity_plus/CHANGELOG.md b/packages/connectivity_plus/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+
 ## 1.1.4
 
 * Update connectivity_plus to 4.0.1.

diff --git a/packages/connectivity_plus/example/pubspec.yaml b/packages/connectivity_plus/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the connectivity_plus_tizen plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   connectivity_plus: ^4.0.1

diff --git a/packages/connectivity_plus/pubspec.yaml b/packages/connectivity_plus/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/connec
 version: 1.1.4
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 flutter:
   plugin:

diff --git a/packages/device_info_plus/CHANGELOG.md b/packages/device_info_plus/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+
 ## 1.2.0
 
 * Add `TizenDeviceInfo.data` which represents the device info as a map.

diff --git a/packages/device_info_plus/example/pubspec.yaml b/packages/device_info_plus/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the device_info_plus_tizen plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   device_info_plus_tizen:

diff --git a/packages/device_info_plus/pubspec.yaml b/packages/device_info_plus/pubspec.yaml
@@ -6,8 +6,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/device
 version: 1.2.0
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 flutter:
   plugin:

diff --git a/packages/firebase_core/CHANGELOG.md b/packages/firebase_core/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## NEXT
 
-* Increase the minimum Flutter version to 3.3.
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
+* Fixes new lint warnings.
 
 ## 0.1.1
 

diff --git a/packages/firebase_core/example/pubspec.yaml b/packages/firebase_core/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: An example application demonstrating calls to Firebase Core.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   firebase_core: ^2.4.0

diff --git a/packages/firebase_core/lib/firebase_app_tizen.dart b/packages/firebase_core/lib/firebase_app_tizen.dart
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license
 // that can be found in the LICENSE file.
 
-part of firebase_core_tizen;
+part of 'firebase_core_tizen.dart';
 
 /// A Dart only implementation of a Firebase app instance.
 class FirebaseApp extends FirebaseAppPlatform {

diff --git a/packages/firebase_core/pubspec.yaml b/packages/firebase_core/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/fireba
 version: 0.1.1
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   firebase_core_dart: ^1.0.1

diff --git a/packages/flutter_app_badger/CHANGELOG.md b/packages/flutter_app_badger/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## NEXT
 
-* Increase the minimum Flutter version to 3.3.
+* Updates minimum supported SDK version to Flutter 3.13/Dart 3.1.
 
 ## 0.1.0
 

diff --git a/packages/flutter_app_badger/example/pubspec.yaml b/packages/flutter_app_badger/example/pubspec.yaml
@@ -3,8 +3,8 @@ description: Demonstrates how to use the flutter_app_badger_tizen plugin.
 publish_to: "none"
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 dependencies:
   flutter:

diff --git a/packages/flutter_app_badger/pubspec.yaml b/packages/flutter_app_badger/pubspec.yaml
@@ -5,8 +5,8 @@ repository: https://github.com/flutter-tizen/plugins/tree/master/packages/flutte
 version: 0.1.0
 
 environment:
-  sdk: ">=2.18.0 <4.0.0"
-  flutter: ">=3.3.0"
+  sdk: ">=3.1.0 <4.0.0"
+  flutter: ">=3.13.0"
 
 flutter:
   plugin: