refactor: 신입 모집 마감 날짜 수정 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
2yunseong
requested changes
Aug 29, 2024
Comment on lines
201
to
208
| export const END_DATE = { | ||
| year: 2024, | ||
| month: 9, | ||
| date: 15, | ||
| hours: 15, | ||
| minutes: 0, | ||
| seconds: 0, | ||
| }; |
There was a problem hiding this comment.
위의 JS DOC도 최신화 해주면 좋겠네요!
There was a problem hiding this comment.
DOC를 최신화 해주실 때 혹시 UTC라서 9시간 차이나는 것도 추가해주실 수 있으신가요??
geongyu09
approved these changes
Aug 30, 2024
| @@ -17,6 +17,7 @@ import { | |||
| applicationDataAtom, | |||
| applicationIndexAtom, | |||
| } from "../stores/application"; | |||
| import { END_DATE } from "../constants/application/28"; | |||
There was a problem hiding this comment.
동적 import 를 사용해도 좋을 것 같습니다! 다만 지금도 충분히 좋아 보입니다!
loopy-lim
reviewed
Aug 30, 2024
Comment on lines
201
to
208
| export const END_DATE = { | ||
| year: 2024, | ||
| month: 9, | ||
| date: 15, | ||
| hours: 15, | ||
| minutes: 0, | ||
| seconds: 0, | ||
| }; |
There was a problem hiding this comment.
DOC를 최신화 해주실 때 혹시 UTC라서 9시간 차이나는 것도 추가해주실 수 있으신가요??
Comment on lines
88
to
98
| if ( | ||
| Date.now() > | ||
| Date.UTC( | ||
| END_DATE.year, | ||
| END_DATE.month - 1, | ||
| END_DATE.date, | ||
| END_DATE.hours, | ||
| END_DATE.minutes, | ||
| END_DATE.seconds | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
항상... 무섭네요...ㅠㅠㅠ
흠... 이렇게 작성하려면 UTC말도 더 좋은 방법이 있는지 고민해봐도 좋을 것 같다는 생각이 듭니다...
There was a problem hiding this comment.
제가 콘솔문 출력하면서 시간 비교하여 올바르게 동작하는지 검증하였는데 틀린 부분 있으면 말씀해주세요
smb0123
commented
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
리뷰어에게...
관련 이슈
closes #173
체크리스트
reviewers설정label설정milestone설정