fix: 첨부링크가 post 요청하지 못하는 이슈를 해결한다 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loopy-lim
approved these changes
Mar 3, 2024
|
|
931fe5e 커밋 추가했는데.. 어떤가요? |
loopy-lim
reviewed
Mar 3, 2024
Comment on lines
59
to
78
| portfolio && | ||
| sendValues.push({ | ||
| name: "portfolio", | ||
| answer: portfolio, | ||
| }); | ||
| fileUrl && | ||
| sendValues.push({ | ||
| name: "fileUrl", | ||
| answer: fileUrl, | ||
| }); | ||
| doubleMajor && | ||
| sendValues.push({ | ||
| name: "doubleMajor", | ||
| answer: doubleMajor, | ||
| }); | ||
| minor && | ||
| sendValues.push({ | ||
| name: "minor", | ||
| answer: minor, | ||
| }); |
There was a problem hiding this comment.
@baegyeong
이 코드는 다시보니... 네... 좀 그렇습니다... ㅋㅋㅋ 그래서 조금 다른 방식을 추천 해드립니다.
getApplicationNames(node)를 받는 부분에서 requirement라는 파라미터를 추가하여 default는 true로 하여 만들면 크게 코드 안고치고 할 수 있지 않을까요?
There was a problem hiding this comment.
저도 하면서 좀...ㅋㅋㅋㅋㅋ 바꿔보겠읍니다..
미ㅏ쳐ㅑㅆ다.... ㄷㄷㄷㄷ |
- pdf viewer에 포트폴리오를 추가한다
loopy-lim
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
리뷰어에게...
수정이 필요한 부분이 있다면 알려주세요.
관련 이슈
closes #101
체크리스트
reviewers설정label설정milestone설정