[REFACTOR] 코멘트 내용 글자수 500자 제한 해제 #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daae-Kim
approved these changes
Nov 30, 2024
kssumin
approved these changes
Dec 13, 2024
| @DisplayName("내용 길이가 500자 이상일 경우 예외가 발생하지 않는다.") | ||
| void createTest() { | ||
| // given | ||
| String length_501_word = |
There was a problem hiding this comment.
Suggested change
| String length_501_word = | |
| String length_501_word = new Random().ints(32, 127) | |
| .limit(501) | |
| .mapToObj(i -> String.valueOf((char) i)) | |
| .collect(Collectors.joining()); | |
| } |
이런식으로 랜덤 문자열을 생성해보는 건 어떨까요? 나중에 규칙이 변하더라도 쉽게 변경가능할 것 같아요~!
kssumin
requested changes
Dec 13, 2024
| username: root | ||
| password: root | ||
| password: gksktodaud1! |
There was a problem hiding this comment.
해당 설정들 변경 이유를 알 수 있을까요?
만약 이 부분이 변경되면 docker-compose 파일도 변경이 되어야 할 것 같습니다.
| @@ -4,5 +4,5 @@ spring: | |||
| on-profile: local-redis | |||
| redis: | |||
| host: localhost | |||
| port : 16379 | |||
| port : 6379 | |||
There was a problem hiding this comment.
엇 그 파일 로컬에서 테스트 하기 위해서 변경했는데 같이 커밋이 되었나보네요 ㅠ 얼른 수정하겠습니다~
added 2 commits
December 13, 2024 17:47
- application-local-mysql : 접속 포트 번호 및 password - application-redis : 접속 포트 번호
- 고정 문자열에서 문자열 랜덤 생성으로 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#184
✒️ 작업 내용
코멘트 생성시 validateCreate 로, 글자수 500자 초과인지 검증을 하고 있는데, 이 로직을 수정하여 글자수 500자 제한을 없앴습니다.
이전에 글자수 제한이 500자였다는 것을 기록하기 위해서, 로직 삭제하지 않고 로직을 변경하였습니다.
스크린샷 🏞️ (선택)
💬 REVIEWER에게 요구사항 💬