Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference files for tests of automatic concatenation of complementary ODB columns #210

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

wsmigaj
Copy link
Contributor

@wsmigaj wsmigaj commented Dec 9, 2024

Description

This PR contains reference ODB files used by tests added in the accompanying ioda PR, https://github.com/JCSDA-internal/ioda/pull/1396.

Issue(s) addressed

Contributes to the resolution of https://github.com/JCSDA-internal/ioda/issues/1143 and https://github.com/JCSDA-internal/ioda/issues/1364.

Dependencies

None

Impact

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@twsearle twsearle added coordinate merge Ready for merge but needs to be coordinated with other repos and removed coordinate merge Ready for merge but needs to be coordinated with other repos labels Dec 13, 2024
@twsearle
Copy link
Contributor

This all works well in my testing thanks! I added the coordinated merge tag before realising these are new files so as long as this change is merged before the other associated changes the tests ought to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants