Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the unit of electron density from m-3 to cm-3 following model naming convention #1595

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

huishao-r
Copy link
Collaborator

@huishao-r huishao-r commented Dec 10, 2024

Description

electron density unit should be cm^-3, instead of m^-3, since the model geoval unit will be cm^-3. Here is the Model geoval naming convention

Issue(s) addressed

This change will ensure the same unit implemented for electron density observed values, geoval values and h(x) values.

Dependencies

Impact

converted ionosonde obs files will be updated with new unit and values.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@huishao-r huishao-r self-assigned this Dec 10, 2024
@huishao-r huishao-r marked this pull request as ready for review December 10, 2024 03:33
@BenjaminRuston BenjaminRuston self-requested a review December 10, 2024 18:43
@BenjaminRuston
Copy link
Collaborator

@huishao-r a file got added with ^M at the end of every line!

and seemed like it was maybe from git? anyway fixed it and added conversion to density_conf as well

@BenjaminRuston BenjaminRuston changed the title Change the unit of electron density from m-3 to cm-3 following naming convention Change the unit of electron density from m-3 to cm-3 following model naming convention Dec 10, 2024
Copy link
Collaborator

@BenjaminRuston BenjaminRuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does the conversion to number per cubic centimeter, which isn't SI but apparently follows model conventions

@BenjaminRuston BenjaminRuston requested a review from fcvdb December 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants