New "resubmit" mechanism #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Dec 8, 2023
| @@ -130,6 +131,8 @@ impl Output for Quiet { | |||
| ) { | |||
| } | |||
|
|
|||
| fn print_task_ids(&self, _job_task_ids: Vec<(JobId, IntArray)>) {} | |||
There was a problem hiding this comment.
I think that here we could write one ID per line? This mode should really be renamed from quiet to something like bash-processable :)
There was a problem hiding this comment.
I have changed it. if there are 2 or more jobs, it prints also job ids.
| .filter(|info| !is_terminated(info)) | ||
| .map(|info| info.n_tasks) | ||
| .sum(); | ||
| let mut remaining_job_ids: BTreeSet<JobId> = jobs |
There was a problem hiding this comment.
Any particular reason why Set was switched to BTreeSet and why the Vec was changed to a slice?
There was a problem hiding this comment.
Because we need to random removes & sorted iterator for creating IntArray.
Kobzol
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preparation for removing resubmit.
It allows "resubmit" via:
(This PR does not removes resubmit yet)