Skip to content

Commit

Permalink
Update glibc version used on CI to 2.28
Browse files Browse the repository at this point in the history
This is required because the GitHub Actions no longer supports the legacy base image that used 2.17.
  • Loading branch information
Kobzol committed Nov 28, 2024
1 parent 16a7861 commit e2510cb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 18 deletions.
20 changes: 7 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
sha: ${{ env.HQ_SHA }}
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set version
run: |
echo "HQ_VERSION=${{ inputs.version || 'dev' }}" | tee -a $GITHUB_ENV
Expand All @@ -33,19 +33,13 @@ jobs:
build-binaries-x64:
needs: [ set-env ]
runs-on: ubuntu-latest
env:
# We need to avoid using NodeJS v20, because it doesn't work with glibc 2.17.
# See https://github.com/actions/checkout/issues/1809.
ACTIONS_RUNNER_FORCED_INTERNAL_NODE_VERSION: node16
ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
# Use a container with GLIBC 2.17
container: quay.io/pypa/manylinux2014_x86_64
# Use a container with GLIBC 2.28
container: quay.io/pypa/manylinux_2_28_x86_64
steps:
- name: Show GLIBC
run: ldd --version
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.set-env.outputs.sha }}
- name: Install stable toolchain
Expand Down Expand Up @@ -96,7 +90,7 @@ jobs:
name: arm64-linux
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.set-env.outputs.sha }}
- name: Install stable toolchain
Expand Down Expand Up @@ -136,7 +130,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
- uses: Swatinem/[email protected]
with:
key: pyhq
Expand All @@ -148,7 +142,7 @@ jobs:
with:
docker-options: -e HQ_BUILD_VERSION=${{ needs.set-env.outputs.version }}
maturin-version: 1.3.0
manylinux: 2014
manylinux: 2_28
command: build
args: --manifest-path crates/pyhq/Cargo.toml --profile dist --out wheels
- name: Install Python wheel
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
version: ${{ env.HQ_VERSION }}
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set HQ nightly version
run: |
echo "HQ_VERSION=nightly-$(date +'%Y-%m-%d')-${{ github.sha }}" >> $GITHUB_ENV
Expand All @@ -28,7 +28,7 @@ jobs:
needs: [ set-env, build-artifacts ]
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Create tag
uses: rickstaa/action-create-tag@v1
with:
Expand All @@ -40,7 +40,7 @@ jobs:
needs: [ create-tag ]
steps:
- name: Checkout sources
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Generate changelog
run: python3 scripts/extract_changelog.py DEV > generated-changelog.md
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ jobs:
echo "Tag: ${{ env.TAG }}"
build:
runs-on: ubuntu-latest
needs: [set-env]
needs: [ set-env ]
env:
container: ghcr.io/it4innovations/hyperqueue
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ needs.set-env.outputs.sha }}

Expand Down

0 comments on commit e2510cb

Please sign in to comment.