Skip to content

Commit

Permalink
Use download-artifact@v3 and upload-artifact@v3
Browse files Browse the repository at this point in the history
  • Loading branch information
Kobzol committed Sep 12, 2024
1 parent e493472 commit 657b5aa
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
echo "::set-output name=archive-name::$ARCHIVE_NAME"
- name: Store archive
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: archive-x64
path: ${{ steps.archive.outputs.archive-name }}
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
echo "::set-output name=archive-name::$ARCHIVE_NAME"
- name: Store archive
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: archive-${{ matrix.name }}
path: ${{ steps.archive.outputs.archive-name }}
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
source venv/bin/activate
python3 -m pytest tests/pyapi
- name: Upload test artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: archive-pyhq
path: wheels/hyperqueue-*.whl
8 changes: 4 additions & 4 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
run: |
echo "HQ version: ${{ env.HQ_VERSION }}"
build-artifacts:
needs: [set-env]
needs: [ set-env ]
uses: ./.github/workflows/build.yml
with:
version: ${{ needs.set-env.outputs.version }}
create-tag:
runs-on: ubuntu-latest
needs: [set-env, build-artifacts]
needs: [ set-env, build-artifacts ]
steps:
- name: Checkout sources
uses: actions/checkout@v3
Expand All @@ -37,7 +37,7 @@ jobs:
message: Nightly build ${{ needs.set-env.outputs.version }}
create-release:
runs-on: ubuntu-latest
needs: [create-tag]
needs: [ create-tag ]
steps:
- name: Checkout sources
uses: actions/checkout@v3
Expand All @@ -46,7 +46,7 @@ jobs:
run: python3 scripts/extract_changelog.py DEV > generated-changelog.md

- name: Download artifacts
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3

- name: Prepare release name
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Check package versions
run: python scripts/check_package_versions.py
set-env:
needs: [version-check]
needs: [ version-check ]
runs-on: ubuntu-latest
outputs:
sha: ${{ env.SHA }}
Expand Down Expand Up @@ -49,14 +49,14 @@ jobs:
echo "Tag: ${{ env.TAG }}"
echo "Pre-release: ${{ env.PRERELEASE }}"
build-artifacts:
needs: [set-env]
needs: [ set-env ]
uses: ./.github/workflows/build.yml
with:
version: ${{ needs.set-env.outputs.tag }}
sha: ${{ needs.set-env.outputs.sha }}
create-release:
runs-on: ubuntu-latest
needs: [set-env, build-artifacts]
needs: [ set-env, build-artifacts ]
steps:
- name: Checkout sources
uses: actions/checkout@v2
Expand All @@ -67,7 +67,7 @@ jobs:
run: python3 scripts/extract_changelog.py ${{ needs.set-env.outputs.tag }} > generated-changelog.md

- name: Download artifacts
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3

- name: Create release
uses: ncipollo/release-action@v1
Expand All @@ -83,11 +83,11 @@ jobs:
artifacts: archive-*/**
upload-python-wheel:
runs-on: ubuntu-latest
needs: [set-env, create-release]
needs: [ set-env, create-release ]
if: ${{ !fromJSON(needs.set-env.outputs.prerelease) }}
steps:
- name: Download archive
uses: actions/download-artifact@v4.1.7
uses: actions/download-artifact@v3
- name: Install twine
run: python -m pip install twine
- name: Upload wheel
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
run: tar -cvf artifacts.tar /tmp/pytest-*

- name: Upload test artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: always() && steps.python_test.outcome == 'failure'
with:
name: pytest artifacts
Expand Down

0 comments on commit 657b5aa

Please sign in to comment.