Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare httpClient variable. #980

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Declare httpClient variable. #980

merged 2 commits into from
Sep 30, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Sep 20, 2023

GitHub Issue: #975

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Removes a deprecation notice outlined in the above issue.

What's new?

Declare a variable that was being dynamically assigned.

How should this be tested?

Testing instructions to come.

Edit: Not sure how to make the errors show up, but an IDE (the built-in one in site-template) shows the lack of declaration of this variable as a problem.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? nobody
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@alxp, @Islandora/committers

@rosiel
Copy link
Member Author

rosiel commented Sep 20, 2023

@rosiel rosiel requested a review from alxp September 27, 2023 17:08
@alxp alxp merged commit f7a7782 into Islandora:2.x Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants