Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Functional Javascript CI tests #1004

Merged
merged 13 commits into from
Apr 24, 2024
Merged

Fix Functional Javascript CI tests #1004

merged 13 commits into from
Apr 24, 2024

Conversation

adam-vessey
Copy link

@adam-vessey adam-vessey commented Jan 3, 2024

GitHub Issue: #889

What does this Pull Request do?

Fix CI to run functional javascript tests

What's new?

How should this be tested?

Look at the GitHub status checks in this PR

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@adam-vessey adam-vessey marked this pull request as draft January 3, 2024 18:56
@joecorall joecorall force-pushed the fix/functional-tests branch from 21af0db to db3a290 Compare April 23, 2024 10:44
@joecorall joecorall force-pushed the fix/functional-tests branch from ea886ae to 466ecb0 Compare April 23, 2024 11:21
@joecorall joecorall changed the title Theoretical trying to use chromedriver. Fix Functional Javascript CI tests Apr 23, 2024
@joecorall
Copy link
Member

CI is working: https://github.com/Islandora/islandora/actions/runs/8799586955/job/24148931863?pr=1004

Now to fix the broken tests.

@joecorall joecorall force-pushed the fix/functional-tests branch from a9c2651 to 3ff078d Compare April 23, 2024 12:47
@joecorall joecorall marked this pull request as ready for review April 23, 2024 12:47
Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-asu seth-shaw-asu merged commit 54206de into 2.x Apr 24, 2024
24 checks passed
@seth-shaw-asu seth-shaw-asu deleted the fix/functional-tests branch April 24, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants