forked from alxp/islandora
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Functional Javascript CI tests #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecorall
force-pushed
the
fix/functional-tests
branch
from
April 23, 2024 10:44
21af0db
to
db3a290
Compare
joecorall
force-pushed
the
fix/functional-tests
branch
from
April 23, 2024 10:45
db3a290
to
63a2f76
Compare
joecorall
force-pushed
the
fix/functional-tests
branch
from
April 23, 2024 11:21
ea886ae
to
466ecb0
Compare
joecorall
changed the title
Theoretical trying to use chromedriver.
Fix Functional Javascript CI tests
Apr 23, 2024
CI is working: https://github.com/Islandora/islandora/actions/runs/8799586955/job/24148931863?pr=1004 Now to fix the broken tests. |
joecorall
force-pushed
the
fix/functional-tests
branch
from
April 23, 2024 12:47
a9c2651
to
3ff078d
Compare
seth-shaw-asu
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #889
What does this Pull Request do?
Fix CI to run functional javascript tests
What's new?
How should this be tested?
Look at the GitHub status checks in this PR
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers