Skip to content

Commit

Permalink
Pull is required to get the latest drupal base image. (#75)
Browse files Browse the repository at this point in the history
  • Loading branch information
nigelgbanks authored Nov 12, 2024
1 parent ab33f99 commit c5cfdee
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,6 @@ jobs:
rm -fr drupal/rootfs/var/www/drupal/.github
git checkout drupal/rootfs/var/www/drupal/assets/patches/default_settings.txt
REPOSITORY=islandora TAG=latest docker buildx bake \
--pull \
--builder "${{ steps.buildx.outputs.name }}" \
--push
10 changes: 5 additions & 5 deletions README.template.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
- [Docker Compose](#docker-compose)
- [Override](#override)
- [Building](#building)
- [Pulling](#pulling)
- [Pulling Docker Images](#pulling-docker-images)
- [Running / Stoping / Destroying](#running--stoping--destroying)
- [Development Profile](#development-profile)
- [Production Profile](#production-profile)
- [Pushing](#pushing)
- [Pushing Docker Images](#pushing-docker-images)
- [Local Registry](#local-registry)
- [Remote Registry](#remote-registry)
- [Development](#development)
Expand Down Expand Up @@ -82,7 +82,7 @@ cause it is left as an exercise to the reader.
You can build your development environment locally using `docker compose`:

```bash
docker compose --profile dev build
docker compose --profile dev build --pull
```

This builds the Drupal image so that it contains the Starter Site files that you downloaded locally earlier.
Expand Down Expand Up @@ -203,7 +203,7 @@ This can be done with the assistance of [isle-builder] repository.
Now you can perform the build locally by pushing to the local registry:

```bash
REPOSITORY=islandora.io docker buildx bake --builder isle-builder --push
REPOSITORY=islandora.io docker buildx bake --pull --builder isle-builder --push
```

> N.B. If you **do not** override `REPOSITORY` environment variable, the value
Expand Down Expand Up @@ -238,7 +238,7 @@ If you do need produce multi-platform images, you'll need to setup a builder
which is covered under the [Local Registry](#local-registry) section.

```bash
docker buildx bake --builder isle-builder --push
docker buildx bake --pull --builder isle-builder --push
```

> N.B. In this example `REPOSITORY` **is not** overridden, so the value provided
Expand Down

0 comments on commit c5cfdee

Please sign in to comment.