Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require js_cookie for fpa #189

Closed
wants to merge 1 commit into from
Closed

Require js_cookie for fpa #189

wants to merge 1 commit into from

Conversation

joecorall
Copy link
Contributor

@rosiel
Copy link
Contributor

rosiel commented Jan 2, 2025

I see that it's already in FPA 4.0's composer.json, so shouldn't Composer bring it in automatically?

@joecorall
Copy link
Contributor Author

@rosiel - I thought it would, too, but it didn't in #188

@rosiel
Copy link
Contributor

rosiel commented Jan 2, 2025

I suspect that since it's in #188's composer.lock diff, the problem (and i don't know how to solve this) is that it's not being enabled in time. Maybe this PR needs to include it in the config that lists enabled modules?

@joecorall
Copy link
Contributor Author

@rosiel then maybe we need to just enable js_cookie explicitly, which I've modified this PR to only do that.

@joecorall
Copy link
Contributor Author

meh I'll do it in the dependebot PR

@joecorall joecorall closed this Jan 2, 2025
@joecorall joecorall deleted the js-cookie branch January 2, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants