Re #211 Select move from game time properly

There was a problem with how gametime move selection worked:

1. Click a spot on game time (which selects a move in the game)
2. Press right arrow a couple times to select a different move
3. Click the same spot on game time

This should rewind the game back to the spot clicked in game time, but
if you didn't move the mouse between steps 1. and 3., the move wasn't
updated.

Another bug is fixed: any time the user clicked a spot in game time, the
move was updated twice: once on mouse "press" and once on mouse
"release".

src/gui/chartwidget.cpp

@@ -121,19 +121,22 @@ void ChartWidget::resizeEvent(QResizeEvent*)
     updatePolygons();
 }
 
-void ChartWidget::handleMouseEvent(QMouseEvent *event)
+void ChartWidget::handleMouseEvent(QMouseEvent *event, bool deduplicate)
 {
-    if (width() && m_values.size() && (m_values[0].count()>1))
+    if (!width() || !m_values.size() || (m_values[0].count()<2))
     {
-        QPointF p = EVENT_POSITION(event);
-        double multiplierW = ((double)width()) / (m_values[0].count()-1);
-        double x = 0.5 + (p.x() / multiplierW);
-        if (m_lastSentIndicator!=(int)x)
-        {
-            emit halfMoveRequested((int)x);
-            m_lastSentIndicator = (int)x;
-        }
+        return;
+    }
+    QPointF p = EVENT_POSITION(event);
+    double multiplierW = ((double)width()) / (m_values[0].count()-1);
+    double x = 0.5 + (p.x() / multiplierW);
+    int move_index = static_cast<int>(x);
+    if (deduplicate && m_lastSentIndicator==move_index)
+    {
+        return;
     }
+    emit halfMoveRequested(move_index);
+    m_lastSentIndicator = move_index;
 }
 
 #if QT_VERSION < 0x060000
@@ -155,7 +158,7 @@ void ChartWidget::leaveEvent(QEvent *event)
 
 void ChartWidget::mousePressEvent(QMouseEvent *event)
 {
-    handleMouseEvent(event);
+    handleMouseEvent(event, false);
     QWidget::mousePressEvent(event);
 }
 
@@ -165,12 +168,6 @@ void ChartWidget::mouseMoveEvent(QMouseEvent *event)
     QWidget::mouseMoveEvent(event);
 }
 
-void ChartWidget::mouseReleaseEvent(QMouseEvent *event)
-{
-    handleMouseEvent(event);
-    QWidget::mouseReleaseEvent(event);
-}
-
 void ChartWidget::updatePly()
 {
     if (m_values.size() && (m_values[0].count()>1))

src/gui/chartwidget.h

@@ -24,12 +24,11 @@ class ChartWidget : public QWidget
     void halfMoveRequested(int);
 
 protected:
-    void handleMouseEvent(QMouseEvent *event);
+    void handleMouseEvent(QMouseEvent *event, bool deduplicate = true);
     virtual void paintEvent(QPaintEvent* event);
     virtual void resizeEvent(QResizeEvent* event);
     virtual void mousePressEvent(QMouseEvent* event);
     virtual void mouseMoveEvent(QMouseEvent* event);
-    virtual void mouseReleaseEvent(QMouseEvent* event);
 #if QT_VERSION < 0x060000
     virtual void enterEvent(QEvent *event);
 #else