feat: S3 생성 및 동영상 presigned url 조회 구현 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
github-actions
bot
requested review from
bestKUFO,
OziinG,
sseoU and
ywonchae1
ywonchae1
approved these changes
Nov 21, 2024
|
|
||
| @Tag(name = "Video Api", description = "Video 관련 API 목록입니다.") | ||
| public interface VideoApi { | ||
| @Operation(summary = "동영상의 presigned url을 발급받습니다..", description = "담당자: 최민석") |
Comment on lines
19
to
24
| s3: | ||
| access-key: ${AWS_S3_ACCESS_KEY} | ||
| secret-key: ${AWS_S3_SECRET_KEY} | ||
| bucket: ${AWS_S3_BUCKET} | ||
|
|
There was a problem hiding this comment.
요거 환경변수 객체로 분리해서 같이 수정해 주시면 좋을 거 같아요 !!
OziinG
reviewed
Nov 21, 2024
|
|
||
| @Tag(name = "Video Api", description = "Video 관련 API 목록입니다.") | ||
| public interface VideoApi { | ||
| @Operation(summary = "동영상의 presigned url을 발급받습니다..", description = "담당자: 최민석") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 상세 설명
📸 스크린샷
presigned url 조회
동영상 재생
