Fix Charging Bench

.github/workflows/javadocs.yml

@@ -0,0 +1,37 @@
+name: Javadocs
+
+on:
+  push:
+    paths:
+    - 'src/**'
+    - 'pom.xml'
+
+permissions:
+  contents: read
+
+jobs:
+  build:
+    name: Maven build
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Set up JDK 17
+      uses: actions/[email protected]
+      with:
+        distribution: 'adopt'
+        java-version: '17'
+        java-package: jdk
+        architecture: x64
+
+    - name: Cache Maven packages
+      uses: actions/cache@v4
+      with:
+        path: ~/.m2
+        key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+        restore-keys: ${{ runner.os }}-m2
+
+    - name: Build Javadocs
+      run: mvn javadoc:javadoc

.gitignore

@@ -6,6 +6,7 @@
 /.idea/
 /.vscode/
 /data-storage/
+/javadocs/
 
 dependency-reduced-pom.xml
 

pom.xml

@@ -239,7 +239,7 @@
 
                 <configuration>
                     <reportOutputDirectory>${project.basedir}</reportOutputDirectory>
-                    <destDir>docs</destDir>
+                    <destDir>javadocs</destDir>
 
                     <doctitle>Slimefun4 - Javadocs</doctitle>
                     <windowtitle>Slimefun4 - Javadocs</windowtitle>
@@ -344,7 +344,7 @@
         <dependency>
             <groupId>com.github.baked-libs.dough</groupId>
             <artifactId>dough-api</artifactId>
-            <version>0130f8d9ce</version>
+            <version>baf2d79f62</version>
             <scope>compile</scope>
         </dependency>
         <dependency>

src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/VersionsCommand.java

@@ -83,7 +83,7 @@ public void onExecute(@Nonnull CommandSender sender, @Nonnull String[] args) {
                     .append(")").color(ChatColor.GRAY);
             }
 
-            builder.append("\n");
+            builder.append("\n").event((HoverEvent) null);
             // @formatter:on
 
             if (Slimefun.getMetricsService().getVersion() != null) {

src/main/java/io/github/thebusybiscuit/slimefun4/core/services/ThreadService.java

@@ -39,7 +39,7 @@ public Thread newThread(Runnable r) {
      * This is a much better alternative to using
      * {@link BukkitScheduler#runTaskAsynchronously(org.bukkit.plugin.Plugin, Runnable)}
      * as this will show not only the plugin but a useful name.
-     * By default, Bukkit will use "Craft Scheduler Thread - <x> - <plugin>" which is nice to show the plugin but
+     * By default, Bukkit will use "Craft Scheduler Thread - {@literal <x>} - {@literal <plugin>}" which is nice to show the plugin but
      * it's impossible to track exactly what thread that is.
      *
      * @param plugin The {@link JavaPlugin} that is creating this thread
@@ -60,7 +60,7 @@ public void newThread(JavaPlugin plugin, String name, Runnable runnable) {
      * This is a much better alternative to using
      * {@link BukkitScheduler#runTaskTimerAsynchronously(org.bukkit.plugin.Plugin, Runnable, long, long)}
      * as this will show not only the plugin but a useful name.
-     * By default, Bukkit will use "Craft Scheduler Thread - <x> - <plugin>" which is nice to show the plugin but
+     * By default, Bukkit will use "Craft Scheduler Thread - {@literal <x>} - {@literal <plugin>}" which is nice to show the plugin but
      * it's impossible to track exactly what thread that is.
      *
      * @param plugin The {@link JavaPlugin} that is creating this thread

src/test/java/io/github/thebusybiscuit/slimefun4/api/events/TestTalismanActivateEvent.java

@@ -78,23 +78,20 @@ void testEventIsFired() {
         activateAnvilTalisman(true, true);
         server.getPluginManager().assertEventFired(TalismanActivateEvent.class, ignored -> true);
         server.getPluginManager().clearEvents();
+
         // Assert the normal talisman does not activate in the ender chest
         activateAnvilTalisman(false, true);
-        try {
-            server.getPluginManager().assertEventFired(TalismanActivateEvent.class, ignored -> true);
-        } catch (AssertionError ignored) {
-            return; // This is expected; the event should not have fired
-        }
-        server.getPluginManager().clearEvents();
+        Assertions.assertThrows(
+            AssertionError.class,
+            () -> server.getPluginManager().assertEventFired(TalismanActivateEvent.class, ignored -> true)
+        );
 
         // Assert the ender talisman does not activate in the inventory
-        try {
-            activateAnvilTalisman(true, false);
-            server.getPluginManager().assertEventFired(TalismanActivateEvent.class, ignored -> true);
-        } catch (AssertionError ignored) {
-            return; // This is expected; the event should not have fired
-        }
-        server.getPluginManager().clearEvents();
+        activateAnvilTalisman(true, false);
+        Assertions.assertThrows(
+            AssertionError.class,
+            () -> server.getPluginManager().assertEventFired(TalismanActivateEvent.class, ignored -> true)
+        );
     }
 
     @Test