New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 2 #43

Open

Nik-Shalashov wants to merge 2 commits into InteractiveAdvertisingBureau:master from Nik-Shalashov:patch-2

Nik-Shalashov commented Feb 26, 2024

No description provided.

Alexey Tamarevskiy and others added 2 commits

September 19, 2023 17:05


          Fix links to media files

04d9837


          Create redirect-test.xml

5e105d0

seanheinrichs commented Feb 26, 2024

Thank you. I hope this gets merged as all of the samples in our repo are broken. I ported this change over to our codebase. 🚀

A1exKH approved these changes

View reviewed changes

A1exKH left a comment

LGTM.

In scope of this PR:

Was added new file VAST 4.0 Samples/redirect-test.xml
Old links, that returned 403 AccessDenied message, were replaced for valid links on github.
2.1. Old:
<![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro.mp4]]>
New:
<![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro.mp4]]>
2.2. Old:
<![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro-mid-resolution.mp4]]>
New:
<![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro-mid-resolution.mp4]]>
2.3. Old:
<![CDATA[https://iab-publicfiles.s3.amazonaws.com/vast/VAST-4.0-Short-Intro-low-resolution.mp4]]>
New:
<![CDATA[https://github.com/inetra/VAST_Samples/raw/master/VAST/VAST-4.0-Short-Intro-low-resolution.mp4]]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet