Migrate to java 7 to support Android below sdk 26 #39
Conversation
|
Thank you very much for this pull request. Sorry for the delay, I will review now |
|
|
||
| dependencies { | ||
| implementation("com.google.guava:guava:20.0") { |
There was a problem hiding this comment.
I would be really nice to have this library without any external dependencies. Can you see if you can use javax.xml.bind.DatatypeConverter (see https://stackoverflow.com/questions/14413169/which-java-library-provides-base64-encoding-decoding)
There was a problem hiding this comment.
I started with DatatypeConverter but there were couple tricky bits with it. It does not support omitting padding and url safe encoding, when second one can be done, first is a bit of a issue.
| */ | ||
| Instant getConsentRecordCreated(); | ||
| Date getConsentRecordCreated(); |
There was a problem hiding this comment.
Of course this in unavoidable, since Instant is not in Java 7. But now we are breaking API contract which means anybody who updates to latest version will probably have to change their code that uses this library. So we would need to bump the major version number for this release.
There was a problem hiding this comment.
Good point, bumped version to 3.0.0 in gradle file
| @@ -85,7 +84,11 @@ public int getVendorListVersion() { | |||
|
|
|||
| @Override | |||
| public Set<Purpose> getAllowedPurposes() { | |||
| return getAllowedPurposeIds().stream().map(Purpose::valueOf).collect(Collectors.toSet()); | |||
| Set<Purpose> purposes = new HashSet<Purpose>(getAllowedPurposeIds().size()); | |||
|
Hey guys, is there a plan to merge this PR? |
|
See #21 . So far there was no consensus on whether we keep separate fork for Android or downgrade Java version here. |
No description provided.