Add no-unused-styles default import support #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeirola
commented
May 2, 2019
lib/util/stylesheet.js
Outdated
| ) || ( | ||
| node.callee.object.type === 'MemberExpression' && | ||
| node.callee.object.object.type === 'Identifier' && | ||
| astHelpers.getImportSource(node.callee.object.object) === 'react-native' && |
There was a problem hiding this comment.
This can potentially be heavy operation. I wonder if it should be cached in some way. Also, maybe it should be moved as the last check?
There was a problem hiding this comment.
Did bump into some performance issues with unnecessary import checks. Decided to move it as the last check to improve performance.
added 2 commits
May 6, 2019 11:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for identifying unused styles when
StyleSheetisn't imported separately, but instead used through thereact-nativedefault import, for example inFixes #227
Replaces #218