Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compose import #172

Merged

Conversation

kibettheophilus
Copy link
Contributor

@kibettheophilus kibettheophilus commented Sep 26, 2024

Hey @arnaudgiuliani , the import generated when KOIN_USE_COMPOSE_VIEWMODEL is active is org.koin.compose.viewmodel.dsl.viewModel which is unresolved and throws an error Unresolved reference 'viewmodel'.

.Also from the warning when the above argument is inactive says the import should be from org.koin.core.module.dsl.*

@Deprecated("Moved ViewModel DSL package. Remove old imports and use org.koin.core.module.dsl.*

Potential fix for #171

@kibettheophilus kibettheophilus changed the base branch from main to 1.4.0 September 26, 2024 14:38
@kibettheophilus kibettheophilus marked this pull request as ready for review September 26, 2024 14:45
@arnaudgiuliani arnaudgiuliani added this to the 1.4.0 milestone Oct 15, 2024
@arnaudgiuliani
Copy link
Member

Thanks @kibettheophilus

@arnaudgiuliani arnaudgiuliani added the status:accepted Ticket is accepted and will be planned in a milestone label Oct 15, 2024
@arnaudgiuliani
Copy link
Member

this is the case in Koin 4.0. To merge in KA 2.0 branch

@arnaudgiuliani arnaudgiuliani modified the milestones: 1.4.0, 2.0 Oct 15, 2024
@arnaudgiuliani arnaudgiuliani deleted the branch InsertKoinIO:2.0.0 October 16, 2024 15:33
@arnaudgiuliani arnaudgiuliani changed the base branch from 1.4.0 to 2.0.0 October 16, 2024 15:47
@arnaudgiuliani arnaudgiuliani merged commit 6bf112b into InsertKoinIO:2.0.0 Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Ticket is accepted and will be planned in a milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants