-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ajouts conseils gestion RAM #335
Open
clerousset
wants to merge
3
commits into
InseeFrLab:master
Choose a base branch
from
clerousset:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Très bien, mais il manque des exemples simples. Suggestion: utiliser
doremifasolData
et le COG pour convertir des noms de communes/départements/régions en factor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ben c'est marrant, il y aussi la recommandation exactement opposée dans la communauté R : éviter d'utiliser les factors car trop de chausse-trappe 😄
Content que
stringsAsFactors
soit passé àFALSE
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien d'accord avec @RLesur ! Je hais les facteurs et ne les utilise que lorsque j'y suis obligé (faire du ggplot2, en l’occurrence). La différence entre la valeur sous-jacente et la valeur d'affichage est trop perturbante pour moi. Si on veut recommander l'utilisation des
factor
, il va falloir expliquer en détail comment les manipuler dans un autre endroit, parce que c'est loin d'être si évident que ça... (Notamment quand il faut les réordonner, quel enfer !)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clerousset : que proposes-tu sur ce paragraphe? Ma reformulation te convient-elle?