fix: Infinite loop if user has been created without ListBucket permission #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2024 12:27
…ut being linked to) the policy, causing CheckUserCredentialsValid to fail and handleS3ExistingUser to enter an infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this issue, if a user has been created by s3-operator without a policy allowing ListBucket (either because no such policy was attached, or because s3-operator has not yet created the policy and cannot attach it), then the credentialsValid() function fails, and s3-operator assumes the credentials are wrong and exits, only to fail again at the next run (infinite loop).
The merge request moves the credentialsValid() function after the policy attachment, which allows s3-operator to attach a policy to an existing user that does not yet have the ListBucket permission. It also specifies the ListBucket permission in the README.