improve s3 config project injection #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddecrulle
force-pushed
the
s3-config-project
branch
from
0ce785f to
b0c1651
Compare
|
garronej
approved these changes
Dec 18, 2024
Comment on lines
+85
to
+94
| disabled={ | ||
| canInjectPersonalInfos | ||
| ? false | ||
| : s3Config.origin === "deploymentRegion" | ||
| } | ||
| checked={ | ||
| canInjectPersonalInfos || s3Config.origin !== "deploymentRegion" | ||
| ? s3Config.isXOnyxiaDefault | ||
| : false | ||
| } |
There was a problem hiding this comment.
This logic should ideally be handled by the core. The component shouldn't need to be so aware of the intricacies of S3Config management; its responsibility should be limited to rendering the UI and forwarding the relevant user input.
That said, I understand the desire to avoid introducing another type just to adhere strictly to the doctrine, so I'll approve this impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.