Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get error from helm wrapper #534

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Get error from helm wrapper #534

wants to merge 4 commits into from

Conversation

olevitt
Copy link
Contributor

@olevitt olevitt commented Dec 12, 2024

Fix #533 : retrieve and properly log the error when installing a helm package

@github-actions github-actions bot added the helm-wrapper Related to the helm-wrapper library label Dec 12, 2024
Comment on lines +50 to +53
getProcessExecutor(errorStream)
.environment(getEnv(helmConfiguration))
.commandSplit(
addConfigToCommand(command, helmConfiguration) + " --output json")

Check notice

Code scanning / SonarCloud

OS commands should not be vulnerable to argument injection attacks Low

Change this code to not construct OS command arguments from user-controlled data. See more on SonarQube Cloud
Comment on lines +85 to +87
getProcessExecutor(errorStream)
.environment(getEnv(helmConfiguration))
.commandSplit(addConfigToCommand(command, helmConfiguration))

Check notice

Code scanning / SonarCloud

OS commands should not be vulnerable to argument injection attacks Low

Change this code to not construct OS command arguments from user-controlled data. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-wrapper Related to the helm-wrapper library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logs, handling and parsing of Helm install erros
1 participant