Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shape from list in calculated variables #257

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Aug 5, 2024

Summary

cf.

Done

The shapeFrom property of calculated variable objects is now a list of strings.

Done it in a backward compatible way:

  • in Lunatic-Model API: String getShapeFrom() and void setShapeFrom(String responseName) are deprecated but still available
  • in the deserialization feature: a string is allowed for the "shapeFrom" in json source

Introduced List<String> getShapeFromList() and void setShapeFrom(List<String> responseNames) in the API.

Serialization of "shapeFrom" as a string is no longer possible from this version.

@nsenave nsenave requested a review from laurentC35 August 5, 2024 15:57
@nsenave nsenave self-assigned this Aug 5, 2024
Copy link

sonarqubecloud bot commented Aug 5, 2024

@nsenave nsenave merged commit f9cbbc1 into v3-main Aug 6, 2024
2 checks passed
@nsenave nsenave deleted the feat/shape-from-list branch August 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant