Link between Genesis and Kraftwerk #35
Conversation
| data.getQuestionnaires().add(questionnaire); | ||
| } | ||
|
|
||
| // /* Step 2.2 : Get paradata for the survey */ |
There was a problem hiding this comment.
Indiquer pourquoi c'est commenté ou supprimer (Sonar aime pas trop les blocs de code commenté)
| vtlExecute.convertToVtlDataset(data, dataMode, vtlBindings); | ||
| } | ||
|
|
||
| // private void parseParadata(ModeInputs modeInputs, SurveyRawData data) throws NullException { |
|
La PR affecte la branche main, on envoie pas sur la develop avant ? |
| return response.getBody() != null ? Arrays.asList(response.getBody()) : null; | ||
| } | ||
|
|
||
| public List<SurveyUnitUpdateLatest> getUEsLatestState(String idQuestionnaire, List<SurveyUnitId> idUEs) { |
There was a problem hiding this comment.
change name to be coherent with "POST"
There was a problem hiding this comment.
As we are getting a list of SurveyUnit, we decided to keep the get at the beginning of the method name.
| @@ -84,6 +95,18 @@ public ResponseEntity<String> mainLunaticOnly( | |||
| return ResponseEntity.ok(inDirectoryParam); | |||
| } | |||
|
|
|||
| @PutMapping(value = "/main/genesis") | |||
| @Operation(operationId = "mainGenesis", summary = "${summary.mainGenesis}", description = "${description.mainGenesis}") | |||
| public ResponseEntity<String> mainGenesis(@RequestParam("idQuestionnaire") String idQuestionnaire) throws KraftwerkException, IOException { | |||
There was a problem hiding this comment.
Kraftwerk exception is catched
| } | ||
|
|
||
| public static Mode getEnumFromModeName(String modeName) { | ||
| for (Mode mode : Mode.values()) { |
There was a problem hiding this comment.
|
|
||
| private String idQuest; | ||
| private String idCampaign; | ||
| private String idUE; |
There was a problem hiding this comment.
String idUE or SurveyUnitId ?
| } | ||
|
|
||
| public static Mode getEnumFromModeName(String modeName) { | ||
| for (Mode mode : Mode.values()) { |
There was a problem hiding this comment.
| private Path convertToUserPath(String userField) { | ||
| if (userField != null && !"null".equals(userField) && !"".equals(userField)) { | ||
| return Paths.get(userField); | ||
| } else { |
| try { | ||
| if (userField.startsWith("http")) { | ||
| return new URL(userField); | ||
| } else { |
| return null; | ||
| } | ||
|
|
||
| private Path convertToPath(String userField) throws KraftwerkException { |
There was a problem hiding this comment.
convertToPath, convertToUrl in the other class = maybe a class utils
There was a problem hiding this comment.
I moved the two methods in FileUtils
| try { | ||
| variables = DDIReader.getVariablesFromDDI(modeInputsGenesis.getDdiUrl()); | ||
| } catch (KraftwerkException e) { | ||
| log.error(e.getMessage()); |
There was a problem hiding this comment.
Maybe throw exception if no DDI ?
| } | ||
|
|
||
| public Path getInDirectory(String inDirectoryParam) { | ||
| Path inDirectory = Paths.get(defaultDirectory, "in", inDirectoryParam); |
No description provided.