Added unknown variable parent and loop management #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicela
reviewed
Feb 23, 2024
| if(variableName.startsWith(Constants.FILTER_RESULT_PREFIX) | ||
| && variablesMap.hasVariable(variableName.replace(Constants.FILTER_RESULT_PREFIX,"")) | ||
| ){ | ||
| Variable parentVariable = variablesMap.getVariable(variableName.replace(Constants.FILTER_RESULT_PREFIX,"")); |
There was a problem hiding this comment.
I don't understand the wording "parentvariable". It's not the parent as it's not a tree. It's more a "linkedvariable" or "attachedVariable"...
There was a problem hiding this comment.
Finally, we choose "relatedVariable", are you ok ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables not in specs are now linked to their parent if they have a "_" delimiter in their name