Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use sims name when exporting #796

Merged
merged 11 commits into from
Nov 28, 2024
Merged

feat: use sims name when exporting #796

merged 11 commits into from
Nov 28, 2024

Conversation

EmmanuelDemey
Copy link
Collaborator

No description provided.

@EmmanuelDemey EmmanuelDemey linked an issue Oct 29, 2024 that may be closed by this pull request
Libellé erroné quand on exporte un rapport qualité sans les documents (libellé = identifiant) #788
Closed
@EmmanuelDemey EmmanuelDemey linked an issue Oct 30, 2024 that may be closed by this pull request
Gestion des caractères diacritiques dans l'exportation des rapports SIMS du fait de la mention "Rapport qualité" et du nom de la série #784
Closed
@FBibonne FBibonne self-requested a review November 19, 2024 14:39
FBibonne
FBibonne reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@FBibonne FBibonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vérifier qu'il n'est pas nécessaire de supprimer partout les caractères ascii et les longueurs excessives dans les noms de fichier dérivés des noms de sims

@EmmanuelDemey EmmanuelDemey merged commit d024ec8 into main Nov 28, 2024
1 check passed
@EmmanuelDemey EmmanuelDemey deleted the 788-libell-erron-quand-on-exporte-un-rapport-qualit-sans-les-documents-libell--identifiant branch November 28, 2024 17:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBibonne FBibonne FBibonne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EmmanuelDemey @FBibonne