fix: missing validationState when fetching operation #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FBibonne
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Il faudrait revérifier. J'ai l'impression que le code fait le contraire de ce qui est demandé dans l'issue #795
Sinon il faudrait assortir de tests pour vérifier qu'un PUT /operation/validate/id renvoie bien le message d'erreur si l'objet parent série est unpublished . Idem pour un PUT /metadataReport/validate/id
src/main/java/fr/insee/rmes/bauhaus_services/operations/documentations/DocumentationsUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/operations/operations/OperationPublication.java
Show resolved
Hide resolved
FBibonne
approved these changes
Nov 28, 2024
...test/java/fr/insee/rmes/bauhaus_services/operations/operations/OperationPublicationTest.java
Show resolved
Hide resolved
src/test/java/fr/insee/rmes/bauhaus_services/operations/series/SeriesPublicationTest.java
Show resolved
Hide resolved
EmmanuelDemey
force-pushed
the
feat/reuse-error-code-publishing-operations
branch
from
ccbd254 to
0a846db
Compare
EmmanuelDemey
deleted the
feat/reuse-error-code-publishing-operations
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.