Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use player name as team name when solo game #146

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Use player name as team name when solo game #146

merged 2 commits into from
Oct 29, 2024

Conversation

istar410
Copy link
Contributor

Description

Use the player name as team name for solo game registration.

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Fix #126.

KwikKill
KwikKill requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful, you've also removed the team selection field in the join form. Preventing managers and substitutes to join the team.

@istar410
Copy link
Contributor Author

Oups, good catch !

KwikKill
KwikKill approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KwikKill KwikKill merged commit e93d6ba into dev Oct 29, 2024
3 checks passed
@KwikKill KwikKill deleted the fix-solo-game-team branch October 29, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwikKill KwikKill KwikKill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use player name as team name when solo game
2 participants
@istar410 @KwikKill