Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Placement selection #144

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Add Placement selection #144

merged 5 commits into from
Oct 29, 2024

Conversation

KwikKill
Copy link
Member

@KwikKill KwikKill commented Oct 7, 2024 •
edited
Loading

Description

Add tournament seating plan :
image

Add place selection from team view :
image

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Fix #121

@KwikKill KwikKill added enhancement New feature or request priority: emergency to do in first labels Oct 7, 2024
@KwikKill KwikKill marked this pull request as ready for review October 14, 2024 20:05
floflo0
floflo0 requested changes Oct 16, 2024
View reviewed changes
src/components/SeatingPlan.vue Show resolved Hide resolved
src/components/TournamentSeating.vue Show resolved Hide resolved
src/components/SeatingPlan.vue Outdated Show resolved Hide resolved
@KwikKill KwikKill requested a review from floflo0 October 17, 2024 13:52
floflo0
floflo0 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@floflo0 floflo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KwikKill KwikKill merged commit 604d7f2 into dev Oct 29, 2024
3 checks passed
@KwikKill KwikKill deleted the seating-choice branch October 29, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floflo0 floflo0 floflo0 approved these changes

@Dyskal Dyskal Awaiting requested review from Dyskal

@istar410 istar410 Awaiting requested review from istar410

Assignees
No one assigned
Labels
enhancement New feature or request priority: emergency to do in first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place selection in the room
2 participants
@KwikKill @floflo0