Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve navbar UI #138

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Improve navbar UI #138

merged 3 commits into from
Oct 2, 2024

Conversation

istar410
Copy link
Contributor

@istar410 istar410 commented Sep 29, 2024 •
edited
Loading

Description

Improvements to the navbar UI:

  • Fix the gap between the white border and the end of the navbar.
  • Switch the breakpoint from lg (1024px) to xl (1280px).
  • Add scroll to burger menu in case of overflow.

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Screenshots

Before:
Copie d'écran_20240929_164622

After:
Copie d'écran_20240929_164637

@istar410 istar410 added the enhancement New feature or request label Sep 29, 2024
@istar410 istar410 requested a review from KwikKill September 29, 2024 15:07
KwikKill
KwikKill approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@KwikKill KwikKill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KwikKill KwikKill merged commit 15e76df into dev Oct 2, 2024
2 checks passed
@KwikKill KwikKill deleted the fix-navbar branch October 2, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwikKill KwikKill KwikKill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istar410 @KwikKill