Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/bump prost #50

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

F/bump prost #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c56d3b
feat: bump prost
maxrobot Oct 16, 2024
f974802
chore:changelog
maxrobot Oct 16, 2024
a0532f5
fixed relative path
maxrobot Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/injective-test-tube/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 1.13.2-auction.1 - 2024-16-10

### Changed

- Bumped `[email protected]`
Comment on lines +8 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix the date format in the new changelog entry.

The new changelog entry looks good overall, following the established format and providing a clear description of the change. However, there's a small issue with the date format.

Please update the date format to follow the YYYY-MM-DD pattern. The current date "2024-16-10" is invalid as there is no 16th month. It should likely be "2024-10-16" (assuming October 16, 2024).

Apply this change:

-## 1.13.2-auction.1 - 2024-16-10
+## 1.13.2-auction.1 - 2024-10-16

The rest of the changelog entry is well-formatted and clearly describes the version bump for the prost dependency.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## 1.13.2-auction.1 - 2024-16-10
### Changed
- Bumped `[email protected]`
## 1.13.2-auction.1 - 2024-10-16
### Changed
- Bumped `[email protected]`


## 1.13.2-auction - 2024-08-10

### Changed
Expand Down
8 changes: 4 additions & 4 deletions packages/injective-test-tube/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@ edition = "2021"
license = "MIT OR Apache-2.0"
name = "injective-test-tube"
repository = "https://github.com/InjectiveLabs/test-tube"
version = "1.13.2-auction"
version = "1.13.2-auction.1"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

exclude = [ "injective-core", "test_artifacts" ]

[dependencies]
base64 = "0.21.5"
cosmrs = { version = "0.15.0", features = [ "cosmwasm", "rpc" ] }
cosmrs = { version = "0.20.0", features = [ "cosmwasm", "rpc" ] }
cosmwasm-schema = { version = "2.1.1" }
cosmwasm-std = { version = "2.1.0", features = [ "abort", "cosmwasm_1_2", "cosmwasm_1_3", "cosmwasm_1_4", "cosmwasm_2_0", "iterator", "stargate" ] }
hex = "0.4.2"
injective-cosmwasm = { version = "0.3.0" }
injective-std = { version = "=1.13.2-auction" }
prost = "0.12.3"
prost = { version = "0.13.3", features = [ "prost-derive" ] }
serde = "1.0.144"
serde_json = "1.0.85"
test-tube-inj = { version = "2.0.1" }
test-tube-inj = { version = "2.0.2" }
thiserror = "1.0.34"

[build-dependencies]
Expand Down
3 changes: 2 additions & 1 deletion packages/injective-test-tube/src/module/auction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ mod tests {
response.params,
Some(Params {
auction_period: 604800,
min_next_bid_increment_rate: 2_500_000_000_000_000u128.to_string()
min_next_bid_increment_rate: 2_500_000_000_000_000u128.to_string(),
inj_basket_max_cap: "".to_string(),
})
);

Expand Down
10 changes: 8 additions & 2 deletions packages/injective-test-tube/src/module/exchange.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,31 +17,31 @@
where
R: Runner<'a>,
{
fn_execute! {

Check failure on line 20 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgInstantSpotMarketLaunchResponse: prost::Message` is not satisfied

Check failure on line 20 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgInstantSpotMarketLaunchResponse: prost::Message` is not satisfied
pub instant_spot_market_launch: v1beta1::MsgInstantSpotMarketLaunch => v1beta1::MsgInstantSpotMarketLaunchResponse
}

fn_execute! {

Check failure on line 24 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgCreateSpotLimitOrderResponse: prost::Message` is not satisfied

Check failure on line 24 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgCreateSpotLimitOrderResponse: prost::Message` is not satisfied
pub create_spot_limit_order: v1beta1::MsgCreateSpotLimitOrder => v1beta1::MsgCreateSpotLimitOrderResponse
}

fn_execute! {

Check failure on line 28 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgCreateDerivativeLimitOrderResponse: prost::Message` is not satisfied

Check failure on line 28 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgCreateDerivativeLimitOrderResponse: prost::Message` is not satisfied
pub create_derivative_limit_order: v1beta1::MsgCreateDerivativeLimitOrder => v1beta1::MsgCreateDerivativeLimitOrderResponse
}

fn_execute! {

Check failure on line 32 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgCancelSpotOrderResponse: prost::Message` is not satisfied

Check failure on line 32 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgCancelSpotOrderResponse: prost::Message` is not satisfied
pub cancel_spot_order: v1beta1::MsgCancelSpotOrder => v1beta1::MsgCancelSpotOrderResponse
}

fn_execute! {

Check failure on line 36 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgCancelDerivativeOrderResponse: prost::Message` is not satisfied

Check failure on line 36 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgCancelDerivativeOrderResponse: prost::Message` is not satisfied
pub cancel_derivative_order: v1beta1::MsgCancelDerivativeOrder => v1beta1::MsgCancelDerivativeOrderResponse
}

fn_execute! {

Check failure on line 40 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgBatchUpdateOrdersResponse: prost::Message` is not satisfied

Check failure on line 40 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgBatchUpdateOrdersResponse: prost::Message` is not satisfied
pub batch_update_orders: v1beta1::MsgBatchUpdateOrders => v1beta1::MsgBatchUpdateOrdersResponse
}

fn_execute! {

Check failure on line 44 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Lints 

the trait bound `injective_std::types::injective::exchange::v1beta1::MsgInstantPerpetualMarketLaunchResponse: prost::Message` is not satisfied

Check failure on line 44 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

the trait bound `MsgInstantPerpetualMarketLaunchResponse: prost::Message` is not satisfied
pub instant_perpetual_market_launch: v1beta1::MsgInstantPerpetualMarketLaunch => v1beta1::MsgInstantPerpetualMarketLaunchResponse
}

Expand Down Expand Up @@ -138,7 +138,7 @@
cosmos::base::v1beta1::Coin as SDKCoin,
injective::exchange::v1beta1,
};
use prost::Message;

Check warning on line 141 in packages/injective-test-tube/src/module/exchange.rs

View workflow job for this annotation

GitHub Actions / Test Suite 

unused import: `prost::Message`

use crate::{Account, Authz, Exchange, InjectiveTestApp};
use test_tube_inj::Module;
Expand Down Expand Up @@ -175,7 +175,9 @@
sender: signer.address(),
ticker: "INJ/USDT".to_owned(),
base_denom: "inj".to_owned(),
base_decimals: 18u32,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a variable with decimals values why not use it ?

quote_denom: "usdt".to_owned(),
quote_decimals: 6u32,
min_price_tick_size: "10000".to_owned(),
min_quantity_tick_size: "100000".to_owned(),
min_notional: "1".to_owned(),
Expand All @@ -190,7 +192,9 @@
sender: signer.address(),
ticker: "INJ/USDT".to_owned(),
base_denom: "inj".to_owned(),
base_decimals: 18u32,
quote_denom: "usdt".to_owned(),
quote_decimals: 6u32,
min_price_tick_size: "10000".to_owned(),
min_quantity_tick_size: "100000".to_owned(),
min_notional: "1".to_owned(),
Expand All @@ -209,8 +213,10 @@
let expected_response = v1beta1::QuerySpotMarketsResponse {
markets: vec![v1beta1::SpotMarket {
ticker: "INJ/USDT".to_string(),
base_denom: "inj".to_string(),
quote_denom: "usdt".to_string(),
base_denom: "inj".to_owned(),
base_decimals: 18u32,
quote_denom: "usdt".to_owned(),
quote_decimals: 6u32,
maker_fee_rate: "-100000000000000".to_string(),
taker_fee_rate: "1000000000000000".to_string(),
relayer_fee_share_rate: "400000000000000000".to_string(),
Expand Down
4 changes: 2 additions & 2 deletions packages/test-tube/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ edition = "2021"
license = "MIT OR Apache-2.0"
name = "test-tube-inj"
repository = "https://github.com/InjectiveLabs/test-tube"
version = "2.0.1"
version = "2.0.2"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
base64 = "0.21.5"
cosmrs = { version = "0.20.0", features = [ "cosmwasm", "rpc" ] }
cosmwasm-std = { version = "2.1.0", features = [ "abort", "cosmwasm_1_2", "cosmwasm_1_3", "cosmwasm_1_4", "cosmwasm_2_0", "iterator", "stargate" ] }
prost = { version = "0.13.3", default-features = false, features = [ "prost-derive" ] }
prost = { version = "0.13.3", features = [ "prost-derive" ] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing cosmrs Dependency Update

The cosmrs dependency remains at version 0.20.0 in both packages/test-tube/Cargo.toml and packages/injective-test-tube/Cargo.toml. This update was intended as part of the PR objectives but appears to be missing. Please update the cosmrs dependency accordingly to align with the PR goals.

🔗 Analysis chain

Prost dependency updated, but cosmrs update is missing.

The prost dependency has been modified by removing default-features = false. This change will include the default features of prost, which may introduce new functionality or behavior. Please ensure this is intentional and doesn't introduce any conflicts or unexpected behavior in the project.

However, I noticed that the cosmrs dependency version remains unchanged at 0.20.0. The PR objectives mentioned updating both prost and cosmrs dependencies. Could you please clarify if the cosmrs update is still planned or if it has been intentionally omitted?

To confirm the current state of dependencies, you can run:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check current versions of prost and cosmrs in all Cargo.toml files
rg --type toml 'prost.*version|cosmrs.*version' .

Length of output: 493

serde = "1.0.144"
serde_json = "1.0.85"
thiserror = "1.0.34"
Expand Down
Loading