-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/solve_stream_derivative_market_issue #343
Conversation
WalkthroughIn version 1.6.2 of the project, significant updates have been made, including a fix to the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
CHANGELOG.md (1)
6-6
: Possible typo: repeated word.There is a possible typo where a word might be repeated. Ensure that the documentation is clear and free of typographical errors.
- ## [1.6.2] + ## [1.6.2]Tools
LanguageTool
[duplication] ~6-~6: Possible typo: you repeated a word
Context: ...ocumented in this file. ## [1.6.2] ### Fixed - Fixed issue in the `listen_derivative_market_...(ENGLISH_WORD_REPEAT_RULE)
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- pyinjective/async_client.py (1 hunks)
- pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- pyproject.toml
Additional context used
LanguageTool
CHANGELOG.md
[duplication] ~6-~6: Possible typo: you repeated a word
Context: ...ocumented in this file. ## [1.6.2] ### Fixed - Fixed issue in the `listen_derivative_market_...(ENGLISH_WORD_REPEAT_RULE)
Additional comments not posted (1)
pyinjective/async_client.py (1)
Line range hint
2339-2344
:
LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
listen_derivative_market_updates
match the new behavior of handling a single market.
listen_derivative_market_updates
method in theAsyncClient
classSummary by CodeRabbit
New Features
Bug Fixes
Documentation