fix/solve_token_list_parsing_issue #338
Conversation
…tokens list. Regenerated the denoms INI files
WalkthroughThe changes enhance the token management system by modifying the assignment logic in an asynchronous function and restructuring denomination identifiers in configuration files. Key updates include shifting from symbol-based to denomination-based identification for tokens under certain conditions, and transitioning to a factory-based naming convention for denominators, which may improve clarity and interoperability within the ecosystem. Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- pyinjective/async_client.py (1 hunks)
- pyinjective/denoms_devnet.ini (20 hunks)
- pyinjective/denoms_testnet.ini (34 hunks)
Additional comments not posted (37)
pyinjective/denoms_devnet.ini (13)
351-352: Verify the updatedpeggy_denomvalue for [ASTRO].Ensure that the new identifier
ibc/E8AC6B792CDE60AB208CA060CA010A3881F682A7307F624347AB71B6A0B0BF89is correct and consistent with the naming convention.
355-356: Verify the updatedpeggy_denomanddecimalsvalue for [ATOM].Ensure that the new identifier
factory/inj17vytdwqczqz72j65saukplrktd4gyfme5agf6c/atomand the updateddecimalsvalue8are correct and consistent with the naming convention.
411-412: Verify the updatedpeggy_denomanddecimalsvalue for [BINJ].Ensure that the new identifier
factory/inj10q36ygr0pkz7ezajcnjd2f0tat5n737yg6g6d5/binjand the updateddecimalsvalue18are correct and consistent with the naming convention.
527-528: Verify the updatedpeggy_denomvalue for [COKE].Ensure that the new identifier
factory/inj158g7dfclyg9rr6u4ddxg9d2afwevq5d79g2tm6/cokeis correct and consistent with the naming convention.
583-584: Verify the updatedpeggy_denomanddecimalsvalue for [DOT].Ensure that the new identifier
ibc/624BA9DD171915A2B9EA70F69638B2CEA179959850C1A586F6C485498F29EDD4and the updateddecimalsvalue10are correct and consistent with the naming convention.
603-604: Verify the updatedpeggy_denomvalue for [ELON].Ensure that the new identifier
inj10pqutl0av9ltrw9jq8d3wjwjayvz76jhfcfza0is correct and consistent with the naming convention.
731-732: Verify the updatedpeggy_denomvalue for [INJ].Ensure that the new identifier
injis correct and consistent with the naming convention.
843-844: Verify the updatedpeggy_denomvalue for [LIOR].Ensure that the new identifier
factory/inj1cjus5ragdkvpmt627fw7wkj2ydsra9s0vap4zx/lioris correct and consistent with the naming convention.
1055-1056: Verify the updatedpeggy_denomvalue for [PYUSD].Ensure that the new identifier
ibc/4367FD29E33CDF0487219CD3E88D8C432BD4C2776C0C1034FF05A3E6451B8B11is correct and consistent with the naming convention.
1079-1080: Verify the updatedpeggy_denomanddecimalsvalue for [QAT].Ensure that the new identifier
inj1m4g54lg2mhhm7a4h3ms5xlyecafhe4macgsuenand the updateddecimalsvalue8are correct and consistent with the naming convention.
1582-1584: Verify the new section[factory/inj1jfuyujpvvkxq4566r3z3tv3jdy29pqra5ln0yk/kira].Ensure that the new section and its values are correct and consistent with the naming convention.
1838-1840: Verify the new section[unknown].Ensure that the new section and its values are correct and consistent with the naming convention.
1843-1844: Verify the updatedpeggy_denomvalue for [wBTC].Ensure that the new identifier
factory/inj14ejqjyq8um4p3xfqj74yld5waqljf88f9eneuk/inj14au322k9munkmx5wrchz9q30juf5wjgz2cfqkuis correct and consistent with the naming convention.pyinjective/async_client.py (1)
3440-3440: Ensure the new assignment logic forunique_symbolis correct.The assignment of
unique_symbolis changed fromtoken.symboltotoken.denomunder specific conditions. Verify that this change aligns with the intended functionality and does not introduce any side effects.pyinjective/denoms_testnet.ini (23)
541-542: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[AK]section are consistent with the shift towards a factory-based naming convention.
621-622: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[ATOM]section are consistent with the shift towards a factory-based naming convention.
709-710: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[BINJ]section are consistent with the shift towards a factory-based naming convention.
901-902: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[COKE]section are consistent with the shift towards a factory-based naming convention.
1069-1070: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[DOT]section are consistent with the shift towards a factory-based naming convention.
1109-1110: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[ELON]section are consistent with the shift towards a factory-based naming convention.
1401-1402: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[INJ]section are consistent with the shift towards a factory-based naming convention.
1645-1646: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[KIRA]section are consistent with the shift towards a factory-based naming convention.
1729-1730: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[LIOR]section are consistent with the shift towards a factory-based naming convention.
1833-1834: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[MILK]section are consistent with the shift towards a factory-based naming convention.
1985-1986: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[NOBI]section are consistent with the shift towards a factory-based naming convention.
2209-2210: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[PYUSD]section are consistent with the shift towards a factory-based naming convention.
2245-2246: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[QAT]section are consistent with the shift towards a factory-based naming convention.
2425-2426: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[SHURIKEN]section are consistent with the shift towards a factory-based naming convention.
2461-2462: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[SOL]section are consistent with the shift towards a factory-based naming convention.
2969-2970: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[USDC]section are consistent with the shift towards a factory-based naming convention.
2985-2986: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[USDCet]section are consistent with the shift towards a factory-based naming convention.
3005-3006: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[USDT]section are consistent with the shift towards a factory-based naming convention.
3061-3062: LGTM!The changes to the
peggy_denomanddecimalsvalues for the[Unknown]section are consistent with the shift towards a factory-based naming convention.
8536-8539: LGTM!The new entries
[factory/inj1jfuyujpvvkxq4566r3z3tv3jdy29pqra5ln0yk/kira]and[factory/inj1jfuyujpvvkxq4566r3z3tv3jdy29pqra5ln0yk/kirat]are consistent with the shift towards a factory-based naming convention.
8780-8783: LGTM!The new entries
[factory/inj1lhr06p7k3rdgk0knw5hfsde3fj87g2aq4e9a52/binj]and[factory/inj1ljsmrpm3hlth5zk347lqr23rdzm2ktd4aathkl/position]are consistent with the shift towards a factory-based naming convention.
9720-9723: LGTM!The new entries
[factory/inj1s9dzsqrrq09z46ye7ffa9fldg3dt0e2cvx6yla/auction.0]and[factory/inj1sa2wmd8zhf893ex6da8jgnp06pcj2tv59mq457/position]are consistent with the shift towards a factory-based naming convention.
9752-9755: LGTM!The new entries `[factory/inj1sg3yjgjlwhtre
Summary by CodeRabbit
New Features
Bug Fixes
Documentation