Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update gas cost in gas estimator #299

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Jan 25, 2024

  • Updated reference gas cost for all messages in the gas estimator
  • Included different calculation for Post Only orders
  • Updated all proto definitions for Injective Core 1.12.1

@aarmoa aarmoa requested a review from nicolasbaum January 25, 2024 02:05
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c47732) 72.97% compared to head (1d66710) 73.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   72.97%   73.06%   +0.09%     
==========================================
  Files          48       48              
  Lines        3404     3416      +12     
  Branches      303      304       +1     
==========================================
+ Hits         2484     2496      +12     
  Misses        839      839              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nicolasbaum nicolasbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Gas Limit constants seem ok and gas multiplier 1.5 for post limit orders suits the chain gas comsumption

@aarmoa aarmoa merged commit b2758b7 into master Jan 25, 2024
12 checks passed
@aarmoa aarmoa deleted the feat/update_gas_cost_in_gas_estimator branch January 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants