Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/update_creation_msg_liquidate_position #296

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Jan 18, 2024

  • Updated the logic to create the MsgLiquidatePosition message
  • Added a example script on how to broadcast a MsgLiquidatePositions message

…ew example script on how to broadcast a MsgLiquidatePosition
@aarmoa aarmoa requested a review from nicolasbaum January 18, 2024 19:09
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ef9948) 72.97% compared to head (1606c4e) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          48       48           
  Lines        3404     3404           
  Branches      303      303           
=======================================
  Hits         2484     2484           
  Misses        839      839           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nicolasbaum nicolasbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Addition of optional argument for liquidator order allows full usage of message fields.

@aarmoa aarmoa merged commit 6c47732 into master Jan 18, 2024
12 checks passed
@aarmoa aarmoa deleted the fix/update_creation_msg_liquidate_position branch January 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants