Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove cron dependency #260

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Feat/remove cron dependency #260

merged 8 commits into from
Oct 17, 2023

Conversation

aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Oct 16, 2023

  • Refactored timeout height synchroniztion logic to be solved by just using asyncio tasks. Removed dependency on aiocron

@aarmoa aarmoa requested a review from achilleas-kal October 16, 2023 18:41
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8048f0c) 56.52% compared to head (1d0e795) 56.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #260      +/-   ##
==========================================
+ Coverage   56.52%   56.66%   +0.13%     
==========================================
  Files          17       17              
  Lines        2031     2042      +11     
  Branches      240      241       +1     
==========================================
+ Hits         1148     1157       +9     
- Misses        847      848       +1     
- Partials       36       37       +1     
Files Coverage Δ
pyinjective/async_client.py 50.71% <73.33%> (+0.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarmoa aarmoa changed the base branch from master to dev October 17, 2023 20:11
@aarmoa aarmoa merged commit cb38b09 into dev Oct 17, 2023
12 checks passed
@aarmoa aarmoa deleted the feat/remove_chrone_dependency branch October 17, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants