-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix slice init length #254
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe changes involve a modification to the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 15.82% 16.66% +0.84%
==========================================
Files 25 26 +1
Lines 4784 4884 +100
==========================================
+ Hits 757 814 +57
- Misses 3992 4035 +43
Partials 35 35 ☔ View full report in Codecov by Sentry. |
The intention here should be to initialize a slice with a capacity of
2
rather than initializing the length of this slice.The online demo: https://go.dev/play/p/q1BcVCmvidW
Summary by CodeRabbit
TestLoadTokensFromUrl
function for better dynamic handling of token metadata.