feat: bump v1.13.78-RC.1 #519
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
proto/indexer/gen.sh (2)
Line range hint
54-67: Investigate type issues requiring ts-ignoreThe addition of
// @ts-ignorecomments forgetExtensionandsetExtensionmethods suggests underlying type issues. Consider:
- Investigating why these type errors occur
- Fixing the type definitions if possible
- Adding comments explaining why these ignores are necessary if they can't be fixed
Line range hint
46-77: Consider using a more maintainable approach for string replacementsThe current string replacement logic using multiple sed commands could be made more maintainable.
Consider creating a separate configuration file for replacements and using a more structured approach:
+ # Create replacements.json + { + "global": [ + {"from": "@improbable-eng/grpc-web", "to": "@injectivelabs/grpc-web"}, + {"from": "protobufjs/minimal", "to": "protobufjs/minimal.js"} + ], + "dts": [ + {"from": "getExtension():", "to": "// @ts-ignore\n getExtension():"}, + {"from": "setExtension(", "to": "// @ts-ignore\n setExtension("} + ] + } + # Create a helper script: replace.js + const replacements = require('./replacements.json'); + const fs = require('fs'); + const path = require('path'); + function processFile(file, rules) { + let content = fs.readFileSync(file, 'utf8'); + for (const rule of rules) { + content = content.replace(new RegExp(rule.from, 'g'), rule.to); + } + fs.writeFileSync(file, content); + }This approach would make the replacements more maintainable and easier to update.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
proto/indexer/gen.sh(1 hunks)
🔇 Additional comments (3)
proto/indexer/gen.sh (3)
Line range hint 8-42: LGTM! Proto generation setup is well-structured
The proto generation process is properly configured with:
- Thorough cleanup of old generated files
- Appropriate protoc options for TypeScript
- Support for both ESM and CJS outputs
Line range hint 108-114: LGTM! Thorough cleanup process
The final cleanup process effectively removes all temporary files and artifacts.
6-6: Verify compatibility with v1.13.78-RC.1
The script now uses a release candidate version. Please ensure that this version has been properly tested and is stable enough for integration.
Summary by CodeRabbit
New Features
injective_indexerrepository for proto definitions.Improvements
Chores