Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix links to main docs portal #518

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

PavelInjective
Copy link
Contributor

@PavelInjective PavelInjective commented Nov 25, 2024

Summary by CodeRabbit

  • Documentation
    • Simplified the header for the "What is CosmWasm?" section for clarity.
    • Enhanced clarity and accuracy in the auction module documentation, particularly around the auction process and fund handling.
    • Updated links to provide users with more relevant resources.

Copy link

coderabbitai bot commented Nov 25, 2024

Walkthrough

The changes in this pull request involve modifications to documentation files, specifically in the .gitbook/contracts/README.md and .gitbook/core-modules/auction.md. The README file has had its header for the "What is CosmWasm?" section simplified by removing hyperlinks. The auction module documentation has been updated for clarity, particularly regarding the auction process and fund handling, including improved instructions for transferring funds and an updated link for the burn auction pool documentation.

Changes

File Path Change Summary
.gitbook/contracts/README.md Modified header from #### [What is CosmWasm?](./#what-is-cosmwasm-) to #### What is CosmWasm?
.gitbook/core-modules/auction.md Enhanced clarity of auction process instructions, refined wording on fund transfers, and updated link for burn auction pool documentation.

Poem

In the land of code, where bunnies hop,
Changes made, we cheer and stop.
Links are trimmed, and clarity's found,
In auction tales, our joy's unbound.
Hooray for docs, so clear and bright,
A rabbit's dance in the soft moonlight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1dfb4fe and f27c381.

📒 Files selected for processing (2)
  • .gitbook/contracts/README.md (1 hunks)
  • .gitbook/core-modules/auction.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .gitbook/contracts/README.md

@@ -68,7 +68,7 @@ How to use funds that are currently associated with your Injective Address in ba
- If you have existing non-default subaccounts, you'll want to do a[ MsgDeposit ](exchange.md#msgdeposit)to one of your existing non-default subaccountIds and use that subaccountId as the `srcSubaccountId` below.
- If you don't have existing non-default subaccounts, you can do a [MsgDeposit](exchange.md#msgdeposit) to a new default subaccountId, which would be done via importing `getSubaccountId` from `sdk-ts` and setting the `subaccountId` field in [MsgDeposit](exchange.md#msgdeposit) to `getSubaccountId(injectiveAddress, 1)`.

For more info, check out the [burn auction pool docs](https://docs.injective.network/develop/tech-concepts/auction_pool/).
For more info, check out the [burn auction pool docs](https://docs.injective.network/developers/modules/injective/auction).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Documentation link update verified and additional update needed

The PR correctly updates the burn auction documentation link to https://docs.injective.network/developers/modules/injective/auction. However, there is another outdated link in the same file that needs to be updated:

  • Line 71: Updated link to docs.injective.network
  • Line 3: Still using old link https://hub.injective.network/auction/

The old hub.injective.network domain should also be updated to the new documentation portal for consistency.

🔗 Analysis chain

Verify the updated documentation link

The link update to https://docs.injective.network/developers/modules/injective/auction aligns with the PR objective of fixing documentation links.

Let's verify the link's validity and consistency:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the documentation link and check for consistency
# Check if this new link format is used consistently across the documentation

# Search for other occurrences of the old and new link patterns
echo "Checking for old link pattern..."
rg -i "hub\.injective\.network/auction"

echo "Checking for new link pattern..."
rg -i "docs\.injective\.network/developers/modules/injective/auction"

# Check if the new domain is used consistently
echo "Checking for consistency in documentation domain..."
rg -i "docs\.injective\.network"

Length of output: 411


Script:

#!/bin/bash
# Let's try a broader search to understand the documentation link patterns

# Check for any references to injective.network domains
echo "Checking for all injective.network domain references..."
rg -i "injective\.network"

# Check for any .md files that might contain documentation links
echo "Finding all markdown files..."
fd -e md

# Check specifically in the .gitbook directory for link patterns
echo "Checking links in .gitbook directory..."
rg -i "http[s]?://" .gitbook/

Length of output: 35551


Script:

#!/bin/bash
# Let's check the specific auction documentation links in the .gitbook directory
echo "Checking auction-related links in .gitbook..."
rg -i "auction" .gitbook/core-modules/auction.md

# Let's also check if there are any other files referencing the old hub.injective.network domain
echo "Checking for other hub.injective.network references..."
rg -i "hub\.injective\.network" .gitbook/

Length of output: 1674

@ThomasRalee ThomasRalee changed the base branch from dev to chore/cw20-convert-docs November 28, 2024 05:32
@ThomasRalee ThomasRalee merged commit 5952607 into chore/cw20-convert-docs Nov 28, 2024
5 checks passed
@ThomasRalee ThomasRalee deleted the fix/wrong_links branch November 28, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants