-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump v1.13.76 #517
feat: bump v1.13.76 #517
Conversation
WalkthroughThe changes in this pull request focus on updating the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
proto/indexer/gen.sh (1)
Line range hint
1-124
: Consider documenting version compatibility requirementsThe script handles critical proto generation that affects TypeScript interfaces. Consider adding a comment section at the top of the script documenting:
- Minimum required versions of dependencies
- Known compatibility issues
- Breaking changes from previous versions
Example addition:
+#!/bin/bash +# Proto Generation Script for Injective Indexer +# Required versions: +# - Node.js: >= 14.x +# - protoc: >= 3.x +# - TypeScript: >= 4.x +# +# Version compatibility: +# - injective-indexer: v1.13.76 +# Breaking changes from v1.13.62-RC.1: None + ROOT_DIR=./proto/indexer
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
proto/indexer/gen.sh
(1 hunks)
🔇 Additional comments (2)
proto/indexer/gen.sh (2)
Line range hint 115-119
: LGTM: Enhanced cleanup process
The cleanup process has been improved to remove additional file types (*.jse, *.tse, *.jsone) from the output directory, ensuring a cleaner output after generation.
6-6
: Verify version compatibility and breaking changes
The version bump from v1.13.62-RC.1
to v1.13.76
is significant. Let's verify the changes between these versions.
✅ Verification successful
Based on the gathered information, I can now provide the final response:
Version bump is safe to proceed
The version bump from v1.13.62-RC.1 to v1.13.76 is a standard update that follows the established proto generation process. The script maintains the same structure and includes proper cleanup procedures for generated files. The proto generation process:
- Clones the specific version from injective-indexer
- Generates TypeScript definitions with appropriate configurations
- Includes necessary post-generation cleanup and package setup
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for breaking changes between v1.13.62-RC.1 and v1.13.76
# Clone the repo to check changes
rm -rf temp_indexer
git clone https://github.com/InjectiveLabs/injective-indexer.git temp_indexer
cd temp_indexer
# Check commit messages and changed proto files between versions
git log --oneline v1.13.62-RC.1..v1.13.76 -- api/gen/grpc/
# Check if any proto files were modified
git diff --name-status v1.13.62-RC.1..v1.13.76 -- api/gen/grpc/
cd ..
rm -rf temp_indexer
Length of output: 585
Script:
#!/bin/bash
# Let's check the repository structure and any documentation about versioning
fd -t f "README|CHANGELOG" -E node_modules
# Check for any proto files that might be affected
fd -t f "\.proto$" -E node_modules
# Look for any version-related imports or dependencies in the codebase
rg "injective-indexer|@injectivelabs" -A 2 -g "package.json"
# Check for any TypeScript files that import from generated proto
rg "from.*proto.*indexer" -g "*.ts"
Length of output: 25480
Script:
#!/bin/bash
# Let's check the content of gen.sh to understand the proto generation process
cat proto/indexer/gen.sh
# Check if there are any proto files in the indexer directory
fd -t f "\.proto$" proto/indexer/
# Check for any version-related documentation in the proto README
cat proto/README.md
Length of output: 5428
Republished from a local branch |
Summary by CodeRabbit