Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add supported chainId check to cosmostation getAddresses #258

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: add supported chainId check to cosmostation getAddresses #258

merged 1 commit into from
Nov 14, 2023

Conversation

shane-moore
Copy link
Collaborator

@shane-moore shane-moore commented Nov 14, 2023 •
edited
Loading

Changes

  • added checkChainIdSupport check to cosmostation getAddresses, similar to keplr and leap

Testing

  • tried Migaloo network with cosmostation and got error message as expected:
image

@bangjelkoski bangjelkoski merged commit 4814914 into dev Nov 14, 2023
1 check passed
@bangjelkoski bangjelkoski deleted the chore/cosmostation-chain-supported-check branch November 14, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangjelkoski bangjelkoski Awaiting requested review from bangjelkoski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shane-moore @bangjelkoski