Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mapBySymbol support multiple token types #253

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

shane-moore
Copy link
Collaborator

Changes

  • it's possible for a tokenMeta object in tokens.ts to have multiple properties i.e. ibc/spl/cw20s in any combination, and each of these sub properties could be used to create a new denom/tokenMetapair in theTokenMetaUtils this.tokens. therefore, we need to extend mapBySymbolto return results for the various token types instead of returning early if it hitsif (tokenMeta.ibc && tokenMeta.ibc.baseDenom) for example, because there may also be acw20sproperty associated with it, which is the case forUSDC, which has ibcandcw20s` tokens that need to be created

Testing Completed

  • hub bridge now shows USDCet. it's currently being omitted in latest published packages, since mapBySymbol is only returning the ibc property's token meta. I tested with this change, and USDCet shows again
  • checked explorer assets page via yarn link, and all tokens looks good

@bangjelkoski bangjelkoski merged commit 4f961f6 into dev Oct 27, 2023
1 check passed
@bangjelkoski bangjelkoski deleted the chore/symbol-mapping-enhancement branch October 27, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants