chore: mapBySymbol support multiple token types #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
tokenMeta
object intokens.ts
to have multiple properties i.e.ibc
/spl
/cw20s
in any combination, and each of these sub properties could be used to create a newdenom/
tokenMetapair in the
TokenMetaUtils. therefore, we need to extend
mapBySymbolto return results for the various token types instead of returning early if it hits
if (tokenMeta.ibc && tokenMeta.ibc.baseDenom)for example, because there may also be a
cw20sproperty associated with it, which is the case for
USDC, which has
ibcand
cw20s` tokens that need to be createdTesting Completed
mapBySymbol
is only returning theibc
property's token meta. I tested with this change, and USDCet shows againyarn link
, and all tokens looks good