Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yml files for ibc tokens script #249

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

shane-moore
Copy link
Collaborator

@shane-moore shane-moore commented Oct 16, 2023

Changes

-- yaml build scripts will now check if there was any updates to ibcTokenMetadata.json during the build. if so, it will push a new commit to handle the update, which should propogate along with the publish step

How the 'Commit ibcTokenMetadata.json if changed' step works

  1. checks if there is any new diff between the previous ibcTokenMetadata.json and the potentially updated one from the build
  2. if there is a diff, the git add/ git commit logic will execute
  3. if there is no diff, then the git diff --exit-code command will return 0, so the git add/git commit steps will not execute
    Note: took some time to come up with this but seems to work nicely

Testing Completed

  • forked injective-ts -> updated package names to where they would publish to @shane-moore/... instead of to @injectivelabs/. then, I updated the ibcTokenMetadata.json to test the change. I pushed the update to my forked repo under a test branch, which kicked off the github actions pipeline, and it published the new @shane-moore/sdk-ui-ts. I also tried a few more times to verify that it would work over time

@bangjelkoski bangjelkoski merged commit 323beaa into dev Oct 24, 2023
1 check passed
@bangjelkoski bangjelkoski deleted the chore/yaml-update-for-ibc-script branch October 24, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants