-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add AUSD token metadata #195
base: master
Are you sure you want to change the base?
Chore: Add AUSD token metadata #195
Conversation
WalkthroughThe pull request introduces a new token, AUSD, to the project's token metadata and token factory configurations. This involves adding a new entry to the Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
ts-scripts/images/tokens/AUSD.png
is excluded by!**/*.png
📒 Files selected for processing (2)
ts-scripts/data/symbolMeta.ts
(1 hunks)ts-scripts/data/tokenFactory.ts
(1 hunks)
🔇 Additional comments (1)
ts-scripts/data/tokenFactory.ts (1)
465-468
: Ensure deployment address correctness and test coverage.
The new AUSD token entry looks good. However, please verify that:
- The
creator
address (inj1n636d9gzrqggdk66n2f97th0x8yuhfrtx520e7
) is correct and controlled by the intended entity. - The token is properly tested or validated in your codebase and any relevant test environment(s).
AUSD: { | ||
name: 'AUSD', | ||
logo: 'AUSD.png', | ||
symbol: 'AUSD', | ||
decimals: 6, | ||
coinGeckoId: 'agora-dollar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update needed: CoinGecko ID inconsistency detected
The AUSD decimal count (6) is consistently defined across all configuration files and matches the on-chain specifications. However, there's an important inconsistency in the CoinGecko ID:
symbolMeta.ts
definescoinGeckoId: 'agora-dollar'
- All token configuration files have empty CoinGecko IDs (
coinGeckoId: ""
)
This suggests either:
- The CoinGecko ID in
symbolMeta.ts
is outdated and should be empty - The token configuration files need to be updated with the correct CoinGecko ID
Since this affects price fetching functionality, this needs to be resolved to ensure proper token price tracking.
🔗 Analysis chain
Confirm metadata consistency and CoinGecko listing.
These properties for AUSD look fine. Double-check the decimal count (6) matches real on-chain specs, and verify the coinGeckoId
(agora-dollar
) for correct listing.
AUSD metadata consistency verified with on-chain data
The verification shows consistent decimal places (6) across all references to AUSD in the codebase, matching the on-chain specifications found in:
- Bank metadata (mainnet and testnet):
decimals: 6
- Token metadata in various configuration files
However, there's a discrepancy in the CoinGecko ID:
- The symbolMeta.ts file specifies
coinGeckoId: 'agora-dollar'
- But all token configuration files (mainnet.json, testnet.json, factoryTokens) have
coinGeckoId: ""
Let's verify if the CoinGecko ID is correct:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for potential references to AUSD metadata or mismatched decimals.
rg -A3 'AUSD'
Length of output: 6514
Script:
#!/bin/bash
# Search for other potential CoinGecko IDs for AUSD
rg -i "agora.*dollar"
Length of output: 85
Summary by CodeRabbit
AUSD
, including its metadata and mainnet configuration.