[WIP] Backport upstream changes #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Problem: gasWanted is not aligned for process proposal mode * check maxGasWanted
Solution: - add unsafe option to turn off nonce checking
* Problem: no MaxTx set from config for mempool * Update config.go Co-authored-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]> --------- Signed-off-by: mmsqe <[email protected]> Co-authored-by: yihuang <[email protected]>
* Problem: incarnation cache not enabled * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * cache eth sig verification result * fix concurrent incarnations * update deps --------- Signed-off-by: yihuang <[email protected]>
Solution: - keep the benchmark logic closer to real one, only removing the nonce check part
include the fix from cometbft/cometbft#3196
…506) * Problem: disable of create vesting account messages are not complete * Update CHANGELOG.md Signed-off-by: mmsqe <[email protected]> --------- Signed-off-by: mmsqe <[email protected]>
) * Optimize AnteHandle method to skip checks if disabledMsgs is empty * Problem: cometbft not up to date (#505) include the fix from cometbft/cometbft#3196 * Problem: disable of create vesting account messages are not complete (#506) * Problem: disable of create vesting account messages are not complete * Update CHANGELOG.md Signed-off-by: mmsqe <[email protected]> --------- Signed-off-by: mmsqe <[email protected]> * CHANGELOG * Update CHANGELOG.md Signed-off-by: mmsqe <[email protected]> --------- Signed-off-by: mmsqe <[email protected]> Signed-off-by: fx0x55 <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: mmsqe <[email protected]>
* Problem: vote_extensions is not disabled in test * bump sdk
* Problem: no debug files uploaded when timeout in ci 30mins for marked, 1h for all in pytest * Apply suggestions from code review * set both
) * rename * pytest -v -s test_debug_traceblock.py * follow existing practice * update test * update stm * test * add timeout * disable * revert * fix * update deps --------- Co-authored-by: huangyi <[email protected]>
* Problem: unnecessary GetAccount in ante handlers reuse account after verify account balance to avoid get again when check sender sequence * rename * less MakeSigner * cast string * cleanup * fix test * fix lint * cleanup * cleanup test * rm prefix * fix * fix test, account created automatically * rename * fix comment * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * cleanup --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: huangyi <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* Problem: method eth_chainId crashed occasionally add fallback default config to ensure no panic in IsEIP155 check * cleanup --------- Co-authored-by: huangyi <[email protected]>
…#521) * Problem: hash in subscribe newHeads differs from eth_getBlockByNumber * fix test * cleanup
* Problem: block-stm tx executor don't do simple static dependency analysis Solution: - estimate dependencies based on tx fee payer, try to optimise worst case performance. * fix build * customize estimates instead of dependencies * fix context * update api * cleanup * changelog * cleanup * cleanup * cleanup * pre-estimate config * fix lint
* Problem: pre-estimation don't run in parallel * fix build * fix race * cleanup chunking * keep unchanged --------- Co-authored-by: mmsqe <[email protected]>
add evm-denom flag
* Problem: trace block not accurate for dynamic fee transaction fix changelog temp * Update x/evm/keeper/state_transition.go Signed-off-by: yihuang <[email protected]> * avoid mutate config tracer * fix test * adjust test * more test * resolve --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
* Problem: db is double closed when shutdown * fix standAlone
* Problem: no time in Transaction * update deps
* Problem: dependencies are outdated * bump cometbft ibc * cleanup * fix build
* Problem: get unnecessary block result in DoCall * GetProof GetBalance * HeaderByNumber * EstimateGas * TraceCall * fix test
…#536) * Problem: validation broke after transaction conversion with raw field * cleanup * less validate * borrow * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * rm chainid check --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]>
* Problem: opBlockhash broke after sdk50 * cleanup * Apply suggestions from code review * DeleteHeaderHash * add header_hash_num in param * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * Update x/evm/types/key.go Signed-off-by: yihuang <[email protected]> * Apply suggestions from code review * fix build * lint --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]>
* clean up * Problem: default headerHashNum is too large
* Problem: no header hash from fallback historicalInfo * test * keep headerNum no change * align check * more test
* Problem: node can't quit by signal Solution: - cleanup graceful shutdown procedure * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix lint * cleanup --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
* Problem: state overwrite not work in debug trace API * test * fix
Co-authored-by: yihuang <[email protected]>
* Problem: check tx blocks consensus Solution: - try NewConnSyncLocalClientCreator * optional * optional in flags * add log * changelog
* graceful shutdown of websocket * context for unsubscribe logs * added a logger to the log subscription * lint --------- Co-authored-by: mmsqe <[email protected]>
* Problem: build fail without cgo * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * revert --------- Signed-off-by: yihuang <[email protected]>
* Problem: rpc stream overhead even if not used Solution: - init the underlying subscriptions lazily. * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix build * ignore pending tx --------- Signed-off-by: yihuang <[email protected]>
* removed listener closing in gracefully shutdown json-rpc server * just logging error from shutdown json-rpc server --------- Co-authored-by: yihuang <[email protected]>
* Problem: check-tx don't run in parallel Solution: - try with experimental flag * fix test --------- Co-authored-by: mmsqe <[email protected]>
* Problem: no trace detail on insufficient balance * skip check * simple reproduce
* Problem: incorrect balance when no tracer in predecessors * lint
this bug was introduced in 773438f
…trace tx (#559) * Problem: wrong gas price when using basefee of minus one height when trace tx * add basefee req --------- Signed-off-by: mmsqe <[email protected]>
* Problem: nil pointer error with legacy tx format * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]>
* Problem: cometbft is outdated * toolchain * align gomod2nix * update flake lock --------- Co-authored-by: HuangYi <[email protected]>
* Problem: nonce management in batch tx * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to evaluate and backport some or all fixes from the upstream.
Additional issues
eth_getBlockReceiptssee Get receipts by block number ethereum/go-ethereum#19634